20328 Filer - Update change of registration filing processor to work with alternate name changes #2580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lternate name Signed-off-by: Hongjing Chen <Hongjing.Chen@gov.bc.ca>
Signed-off-by: Hongjing Chen <Hongjing.Chen@gov.bc.ca>
JazzarKarim
reviewed
Apr 11, 2024
JazzarKarim
reviewed
Apr 11, 2024
| @@ -511,7 +512,7 @@ def create_office_address(business, office, address_type): | |||
|
|
|||
|
|
|||
| def create_entity_person(party_json): | |||
| """Create a director.""" | |||
| """Create a director/partner/proprietor.""" | |||
JazzarKarim
approved these changes
Apr 11, 2024
JazzarKarim
reviewed
Apr 11, 2024
kzdev420
approved these changes
Apr 12, 2024
argush3
reviewed
Apr 12, 2024
queue_services/entity-filer/src/entity_filer/filing_processors/change_of_registration.py
Show resolved
Hide resolved
Signed-off-by: Hongjing Chen <Hongjing.Chen@gov.bc.ca>
Signed-off-by: Hongjing Chen <Hongjing.Chen@gov.bc.ca>
argush3
reviewed
Apr 15, 2024
...services/entity-filer/src/entity_filer/filing_processors/filing_components/alternate_name.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Hongjing Chen <Hongjing.Chen@gov.bc.ca>
Signed-off-by: Hongjing Chen <Hongjing.Chen@gov.bc.ca>
Signed-off-by: Hongjing Chen <Hongjing.Chen@gov.bc.ca>
argush3
reviewed
Apr 15, 2024
...services/entity-filer/src/entity_filer/filing_processors/filing_components/alternate_name.py
Outdated
Show resolved
Hide resolved
argush3
reviewed
Apr 15, 2024
...services/entity-filer/src/entity_filer/filing_processors/filing_components/alternate_name.py
Outdated
Show resolved
Hide resolved
…e attachment for GP AN records Signed-off-by: Hongjing Chen <Hongjing.Chen@gov.bc.ca>
argush3
reviewed
Apr 16, 2024
...services/entity-filer/src/entity_filer/filing_processors/filing_components/alternate_name.py
Show resolved
Hide resolved
argush3
reviewed
Apr 16, 2024
queue_services/entity-filer/src/entity_filer/filing_processors/filing_components/parties.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Hongjing Chen <Hongjing.Chen@gov.bc.ca>
Signed-off-by: Hongjing Chen <Hongjing.Chen@gov.bc.ca>
|
argush3
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #: /bcgov/entity#20328
Description of changes:
entity_typevalues for registration filing processor sincealternate_names.entity_typewas introduced into dbNaicsServiceandRegistrationBootstrapServicefrom legal-api (alsoBusinessServicein previous PR). The files should be removed once filer can refer to common moduleBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the lear license (Apache 2.0).