Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot upload CSV #501

Closed
dkelsey opened this issue Apr 19, 2018 · 5 comments
Closed

Cannot upload CSV #501

dkelsey opened this issue Apr 19, 2018 · 5 comments
Assignees
@dkelsey
Labels
bug
Milestone
1.7.1

Comments

@dkelsey
Copy link
Contributor

dkelsey commented Apr 19, 2018

ENV

CAT

TESTCASE

  • initiate an upload of a CSV as a resource, following a usual process.
  • Click the 'Add' Button

EXPECTED

  • The CSV resource is added,
  • It is loaded into the DataStore
  • The editor is taken to the Metadata record view page - they are no longer in "edit" mode for the record.
  • the new csv resouce is listed as a resource in the 'Data and Resources' section

ACTUAL

  • Nothing appears to happen
  • the user remains on the Add Resource page
    image.png
@dkelsey dkelsey added the bug label Apr 19, 2018
@jeff-at-h3 jeff-at-h3 added this to the 1.7.1 milestone Apr 19, 2018
@dkelsey
Copy link
Contributor Author

dkelsey commented Apr 20, 2018

I was able to upload a CSV as a resource for a new metadata records but i could not for an older ones.

new :) old :(
New Dataset Test 501
501 Uploading a csv		 Test of CSV Parser
Test Large PDF

jrods added a commit to HighwayThree/ckanext-bcgov that referenced this issue Apr 26, 2018
@jrods
bcgov#501 - Revert resource_storage_location validator
b91cce7 
bcgov#501

Can't use `not_empty` on resource_storage_location currently because when adding or updating resources, if that field is missing from other resources in the dataset, then the new or edited resource fails.
This was referenced Apr 26, 2018
Closed
Merged
@jrods
Copy link
Contributor

jrods commented Apr 30, 2018

So the problem seems to be that adding and updating resources are done as a lump, so updating/adding one resource causes the other resources to go though the validation process at once. For now, the fix is to revert back to using the ignore_missing validator on the resource_storage_location field.

@jrods jrods assigned dkelsey and unassigned jrods Apr 30, 2018
dkelsey added a commit that referenced this issue May 3, 2018
@dkelsey
Merge pull request #504 from HighwayThree/501-storage-location-validator
588bcbb 
#501 - Revert resource_storage_location validator
@dkelsey
Copy link
Contributor Author

dkelsey commented May 18, 2018

Tested these and the all pass.

@dkelsey dkelsey mentioned this issue May 18, 2018
Closed
@dkelsey
Copy link
Contributor Author

dkelsey commented Nov 21, 2018

FAIL

I'm using a dataset that has a number for resources where the some resources do not have the 'resource_storage_location' field:

  • it is not that the field is present and not set; it is that the field is not present.

@dkelsey
Copy link
Contributor Author

dkelsey commented Nov 28, 2018

PASS.

re-tested same test case and it now passes.

@dkelsey dkelsey closed this as completed Nov 28, 2018
@dkelsey dkelsey reopened this Nov 28, 2018
@dkelsey dkelsey closed this as completed Nov 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dkelsey dkelsey

Labels
bug
Projects
None yet
Milestone
1.7.1
Development

No branches or pull requests
3 participants
@dkelsey @jrods @jeff-at-h3