23092 - Cont in Business Only Alter to Cont in Type #590

ArwenQin · 2024-09-20T19:22:49Z

Description of changes:

A C company can alter to a C Type (Cont In ULC, C, CCC, BEN)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the bcrs-entities-create-ui license (Apache 2.0).

Signed-off-by: Qin <Arwen.Qin@gov.bc.ca>

ArwenQin · 2024-09-20T19:23:01Z

/gcbrun

ArwenQin · 2024-09-20T19:31:43Z

Now a Cont in business can alter to other valid Cont in legal types successfully.
Test with:
Cont In ULC to Cont In Benefit or Limited
https://business-edit-dev--pr-590-mkdch8go.web.app/C9900774/alteration?accountid=3040

Cont In Limited to Cont In BEN, ULC, or CCC
https://business-edit-dev--pr-590-mkdch8go.web.app/C9900734/alteration?accountid=3040

src/components/common/YourCompany/ChangeBusinessType.vue

severinbeauvais · 2024-09-20T20:14:32Z

I cannot test the preview links because Auth API is not returning settings or authorizations.

ArwenQin · 2024-09-20T20:17:49Z

I cannot test the preview links because Auth API is not returning settings or authorizations.

Oh yes I see... I tried, not working either

severinbeauvais · 2024-09-20T20:22:31Z

I cannot test the preview links because Auth API is not returning settings or authorizations.

Oh yes I see... I tried, not working either

I will checkout your code and try it locally. (gh pr checkout 590)

severinbeauvais · 2024-09-20T20:28:55Z

OK, I tested locally the first business (C9900774) and the filing JSON looks correct (see below), but I still think there may be an easier solution.

Signed-off-by: Qin <Arwen.Qin@gov.bc.ca>

ArwenQin · 2024-09-23T17:42:53Z

OK, I tested locally the first business (C9900774) and the filing JSON looks correct (see below), but I still think there may be an easier solution.

Hi Sev, I just updated the solution. I also corrected the entityTypeOptions property for C, CBEN and CUL

src/components/common/YourCompany/ChangeBusinessType.vue

src/utils/resource-utils.ts

src/components/common/YourCompany/ChangeBusinessType.vue

severinbeauvais · 2024-09-23T18:08:03Z

Hi Sev, I just updated the solution. I also corrected the entityTypeOptions property for C, CBEN and CUL

OK, this "feels like" the solution I was expecting.

However, I have a done a bit of testing and there are issues (though maybe not caused by this code)...

C9900774 is, at the moment, of type "C". But if try to create a name-change NR for it, business search (from Namerequest UI) says it's type CUL. Please check with Vysakh whether this should have been synced.
Here is the draft alteration filing (where I changed type from C to CBEN). Do you know if filing.alteration.nameRequest.legalType should also be CBEN? (Maybe ask Vysakh again.)

Please test thoroughly, including with new NR to change the business name. Thanks.

Signed-off-by: Qin <Arwen.Qin@gov.bc.ca>

ArwenQin · 2024-09-23T18:16:34Z

/gcbrun

ArwenQin · 2024-09-23T18:17:00Z

Thanks Sev. I just updated the comments/order.
I will check with Vysakh

bcregistry-sre · 2024-09-23T18:19:25Z

Temporary Url for review: https://business-edit-dev--pr-590-mkdch8go.web.app

ArwenQin · 2024-09-23T19:01:17Z

@severinbeauvais
I just did thorough tests, the type alter works well. Only the Namerequest type pending Vysakh's confirmation.
By the way, I found another bug in the 3. Court Order and Plan of Arrangement section:

If I enter the court order number only, and don't check the POA box, there shows no error; but when we file it, there is a schema error.
If we don't enter the court order number, or enter court order number & check the box - all good.
Just to confirm, what is the requirement? Is court order number only + no check box allowed?
Shall I create a new ticket for this?

severinbeauvais · 2024-09-23T19:13:15Z

Just to confirm, what is the requirement? Is court order number only + no check box allowed? Shall I create a new ticket for this?

It should be possible to enter a court number and not check the POA box. This is probably a simple fix you can do in this ticket. According to the court order schema, effectOfOrder is a string but isn't nullable, so you probably need to remove that property if it's empty.

Please test a ChangeOfRegistration ("firm alteration") filing for the same bug, and fix that, too.

If you really want, you can create a new ticket for this. (And then just work on it today.)

Signed-off-by: Qin <Arwen.Qin@gov.bc.ca>

ArwenQin · 2024-09-23T19:53:41Z

src/mixins/filing-template-mixin.ts

@@ -331,7 +332,7 @@ export default class FilingTemplateMixin extends DateMixin {
    if (this.getHasPlanOfArrangement || this.getFileNumber) {
      filing.alteration.courtOrder = {
        fileNumber: this.getFileNumber,
-        effectOfOrder: this.getHasPlanOfArrangement ? EffectOfOrders.PLAN_OF_ARRANGEMENT : null,
+        effectOfOrder: this.getHasPlanOfArrangement ? EffectOfOrders.PLAN_OF_ARRANGEMENT : undefined,
        hasPlanOfArrangement: this.getHasPlanOfArrangement


corrected the EffectOfOrders schema for Court Order section

src/mixins/filing-template-mixin.ts

ArwenQin · 2024-09-23T19:56:02Z

/gcbrun

bcregistry-sre · 2024-09-23T19:59:07Z

Temporary Url for review: https://business-edit-dev--pr-590-mkdch8go.web.app

severinbeauvais · 2024-09-23T20:22:12Z

src/mixins/filing-template-mixin.ts

@@ -209,7 +209,7 @@ export default class FilingTemplateMixin extends DateMixin {
      if (this.getHasPlanOfArrangement || this.getFileNumber) {
        filing.correction.courtOrder = {
          fileNumber: this.getFileNumber,
-          effectOfOrder: this.getHasPlanOfArrangement ? EffectOfOrders.PLAN_OF_ARRANGEMENT : null,
+          effectOfOrder: this.getHasPlanOfArrangement ? EffectOfOrders.PLAN_OF_ARRANGEMENT : undefined,


Please verify by filing a correction with a court order number and with / without a POA.

Tested ok with CP1002614

severinbeauvais · 2024-09-23T20:22:27Z

src/mixins/filing-template-mixin.ts

@@ -647,7 +648,7 @@ export default class FilingTemplateMixin extends DateMixin {
    if (this.getHasPlanOfArrangement || this.getFileNumber) {
      filing.changeOfRegistration.courtOrder = {
        fileNumber: this.getFileNumber,
-        effectOfOrder: this.getHasPlanOfArrangement ? EffectOfOrders.PLAN_OF_ARRANGEMENT : null,
+        effectOfOrder: this.getHasPlanOfArrangement ? EffectOfOrders.PLAN_OF_ARRANGEMENT : undefined,


Please verify by filing a change of registration with a court order number and with / without a POA.

Tested ok with FM1085277

severinbeauvais

The code looks good but please ensure you have tested these scenarios before merging (and also add Test Notes in the ticket to let Riyaz know what you've verified locally):

BC to another type
BEN to another type
CC to another type
ULC to another type
C to another type
CBEN to another type
CCC to another type
CUL to another type
use name change NRs for the above wherever possible (if you find bugs related to this then create another ticket)

Thanks for the good work 👍

severinbeauvais · 2024-09-24T17:17:03Z

/gcbrun

ArwenQin and others added 2 commits September 19, 2024 16:12

updated the alter types for ContIn

727f892

Signed-off-by: Qin <Arwen.Qin@gov.bc.ca>

Merge branch 'bcgov:main' into 23092-ContIn-Alter-To-ContIn-Type

eb0346d

ArwenQin self-assigned this Sep 20, 2024

ArwenQin requested a review from severinbeauvais September 20, 2024 19:26

severinbeauvais reviewed Sep 20, 2024

View reviewed changes

src/components/common/YourCompany/ChangeBusinessType.vue Outdated Show resolved Hide resolved

updated alter type solution, corrected C entity type options

118696f

Signed-off-by: Qin <Arwen.Qin@gov.bc.ca>

severinbeauvais reviewed Sep 23, 2024

View reviewed changes

src/components/common/YourCompany/ChangeBusinessType.vue Outdated Show resolved Hide resolved

severinbeauvais reviewed Sep 23, 2024

View reviewed changes

src/utils/resource-utils.ts Outdated Show resolved Hide resolved

severinbeauvais reviewed Sep 23, 2024

View reviewed changes

src/components/common/YourCompany/ChangeBusinessType.vue Outdated Show resolved Hide resolved

updated comments, order

e14b81e

Signed-off-by: Qin <Arwen.Qin@gov.bc.ca>

ArwenQin mentioned this pull request Sep 23, 2024

Edit UI: Cont. In company can only alter to another Cont. In type company (C, CBEN, CCC, CUL) bcgov/entity#23092

Closed

3 tasks

ArwenQin added 2 commits September 23, 2024 12:46

fix section 3 court order bug

5764ab0

Signed-off-by: Qin <Arwen.Qin@gov.bc.ca>

namerequest.legalType updated to current type

3c48d44

Signed-off-by: Qin <Arwen.Qin@gov.bc.ca>

ArwenQin commented Sep 23, 2024

View reviewed changes

src/mixins/filing-template-mixin.ts Show resolved Hide resolved

bcgov deleted a comment from bcregistry-sre Sep 23, 2024

severinbeauvais reviewed Sep 23, 2024

View reviewed changes

severinbeauvais approved these changes Sep 23, 2024

View reviewed changes

ArwenQin merged commit 47671d9 into bcgov:main Sep 23, 2024
5 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

23092 - Cont in Business Only Alter to Cont in Type #590

23092 - Cont in Business Only Alter to Cont in Type #590

ArwenQin commented Sep 20, 2024

ArwenQin commented Sep 20, 2024

ArwenQin commented Sep 20, 2024

severinbeauvais commented Sep 20, 2024

ArwenQin commented Sep 20, 2024 •

edited

Loading

severinbeauvais commented Sep 20, 2024

severinbeauvais commented Sep 20, 2024 •

edited

Loading

ArwenQin commented Sep 23, 2024

severinbeauvais commented Sep 23, 2024

ArwenQin commented Sep 23, 2024

ArwenQin commented Sep 23, 2024

bcregistry-sre commented Sep 23, 2024

ArwenQin commented Sep 23, 2024

severinbeauvais commented Sep 23, 2024

ArwenQin Sep 23, 2024

ArwenQin commented Sep 23, 2024

bcregistry-sre commented Sep 23, 2024

severinbeauvais Sep 23, 2024

ArwenQin Sep 23, 2024

severinbeauvais Sep 23, 2024

ArwenQin Sep 23, 2024

severinbeauvais left a comment

severinbeauvais commented Sep 24, 2024

23092 - Cont in Business Only Alter to Cont in Type #590

23092 - Cont in Business Only Alter to Cont in Type #590

Conversation

ArwenQin commented Sep 20, 2024

ArwenQin commented Sep 20, 2024

ArwenQin commented Sep 20, 2024

severinbeauvais commented Sep 20, 2024

ArwenQin commented Sep 20, 2024 • edited Loading

severinbeauvais commented Sep 20, 2024

severinbeauvais commented Sep 20, 2024 • edited Loading

ArwenQin commented Sep 23, 2024

severinbeauvais commented Sep 23, 2024

ArwenQin commented Sep 23, 2024

ArwenQin commented Sep 23, 2024

bcregistry-sre commented Sep 23, 2024

ArwenQin commented Sep 23, 2024

severinbeauvais commented Sep 23, 2024

ArwenQin Sep 23, 2024

Choose a reason for hiding this comment

ArwenQin commented Sep 23, 2024

bcregistry-sre commented Sep 23, 2024

severinbeauvais Sep 23, 2024

Choose a reason for hiding this comment

ArwenQin Sep 23, 2024

Choose a reason for hiding this comment

severinbeauvais Sep 23, 2024

Choose a reason for hiding this comment

ArwenQin Sep 23, 2024

Choose a reason for hiding this comment

severinbeauvais left a comment

Choose a reason for hiding this comment

severinbeauvais commented Sep 24, 2024

ArwenQin commented Sep 20, 2024 •

edited

Loading

severinbeauvais commented Sep 20, 2024 •

edited

Loading