20779 Implemented Easy Legal Name Fix #570
Conversation
|
/gcbrun |
|
As I have a PR that I've been working on for a couple of weeks (!) and am final-testing, I'd really appreciate if my PR could go first and then you could apply your changes on top. Is that OK? |
Absolutely, I wanted to mention this to you. Some of it also overlaps with what I have here. So, you can merge yours first and then I'll rebase. No problem! |
86004c2 to
fe72e66
Compare
|
/gcbrun |
| [] | ||
| )) | ||
|
|
||
| // store Provisions Removed | ||
| if (filing.alteration.provisionsRemoved) this.setProvisionsRemoved(true) | ||
|
|
||
| // store Office Addresses **from snapshot** (because we don't change office addresses in an alteration) | ||
| this.setOfficeAddresses(cloneDeep(entitySnapshot.addresses)) | ||
| this.setOfficeAddresses(cloneDeep(entitySnapshot?.addresses || null)) |
There was a problem hiding this comment.
In the future, I think it would be better to check if addresses exists before setting them (and same for all other data below). That way, we can leave the initial values in the store and don't need to re-assign those values here as fallbacks. (Initial values in 1 place only.)
There was a problem hiding this comment.
Got it, noted! Let me know if you want me to change that here.
There was a problem hiding this comment.
Not here. Future.
Issue #: /bcgov/entity#20779
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the bcrs-entities-create-ui license (Apache 2.0).