Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up for the new domain name changes. #486

Merged
merged 1 commit into from
Apr 21, 2023
Merged

Conversation

pwei1018
Copy link
Collaborator

Issue #: 15877

Description of changes:

  1. Clean up unused files;
  2. Enable cloud build PR review feature;
  3. Move firebase and cloud build configuration to UI CD flow in bcregisty-sre repo;
  4. Update environment variables' value;

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the bcrs-entities-create-ui license (Apache 2.0).

@pwei1018 pwei1018 self-assigned this Apr 20, 2023
@pwei1018
Copy link
Collaborator Author

/gcbrun

@pwei1018
Copy link
Collaborator Author

Temporary Url for review: https://business-edit-dev--pr-486-3tpye30o.web.app

@codecov
Copy link

codecov bot commented Apr 20, 2023

Codecov Report

Merging #486 (e82fe26) into main (eaf687f) will increase coverage by 1.11%.
The diff coverage is 90.94%.

@@            Coverage Diff             @@
##             main     #486      +/-   ##
==========================================
+ Coverage   85.70%   86.82%   +1.11%     
==========================================
  Files         177      195      +18     
  Lines        3289     3651     +362     
  Branches      524      445      -79     
==========================================
+ Hits         2819     3170     +351     
  Misses        468      468              
- Partials        2       13      +11     
Impacted Files Coverage Δ
src/components/common/ErrorContact.vue 100.00% <ø> (ø)
...ourCompany/NameTranslations/AddNameTranslation.vue 100.00% <ø> (ø)
...nents/common/YourCompany/NameTranslations/index.ts 100.00% <ø> (ø)
src/dialogs/StaffPaymentErrorDialog.vue 100.00% <ø> (ø)
...-interfaces/PeopleAndRoles/org-person-interface.ts 100.00% <ø> (ø)
...erfaces/state-interfaces/name-request-interface.ts 100.00% <ø> (ø)
src/mixins/common-mixin.ts 69.69% <ø> (-7.05%) ⬇️
src/services/legal-services.ts 93.51% <0.00%> (-6.49%) ⬇️
src/utils/feature-flag-utils.ts 47.05% <ø> (+31.26%) ⬆️
src/views/auth/Signout.vue 100.00% <ø> (ø)
... and 123 more

... and 16 files with indirect coverage changes

Copy link
Collaborator

@severinbeauvais severinbeauvais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved but please fix keys before merging.

@pwei1018 pwei1018 merged commit 3eab389 into bcgov:main Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants