14974 Updated extend time limit section to respond to UXA comments #464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JazzarKarim
commented
Mar 29, 2023
| @@ -29,8 +29,9 @@ | |||
| <section id="approval-type-section" | |||
| class="section-container" | |||
| :class="{ 'invalid-section': !getApprovalTypeValid }" | |||
| v-if="approvalType == ApprovalTypes.VIA_COURT_ORDER" | |||
There was a problem hiding this comment.
This section was taking space although approval type was approved via registrar. Having the v-if here instead of in the template below would get rid of that.
8dd377b to
c21782d
Compare
Codecov Report
@@ Coverage Diff @@
## main #464 +/- ##
==========================================
- Coverage 85.70% 83.84% -1.87%
==========================================
Files 177 192 +15
Lines 3289 3689 +400
Branches 524 722 +198
==========================================
+ Hits 2819 3093 +274
- Misses 468 595 +127
+ Partials 2 1 -1
|
severinbeauvais
approved these changes
Mar 29, 2023
ketaki-deodhar
approved these changes
Mar 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #: /bcgov/entity#14974
Description of changes:
As per Ethan's comments, this PR fixes the style and spacing for the Approval type and the limited restoration radio panel.
Ethan's comments: Edit UI - new section to extend time limit entity#14974 (comment)
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the business-filings-ui license (Apache 2.0).