15092 - remove fee summary components from App.vue add to each view instead #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathan-longe
commented
Mar 17, 2023
Comment on lines
+5
to
+7
| <v-col cols="9" class="left-side"> | ||
| <slot></slot> | ||
| </v-col> |
There was a problem hiding this comment.
The ViewWrapper takes a significant chunk of the template from App.vue. Here we're using a <slot> to allow the views to add back their own content with the minimum of disruption.
Codecov Report
@@ Coverage Diff @@
## main #458 +/- ##
==========================================
- Coverage 85.70% 84.06% -1.65%
==========================================
Files 177 186 +9
Lines 3289 3558 +269
Branches 524 711 +187
==========================================
+ Hits 2819 2991 +172
- Misses 468 566 +98
+ Partials 2 1 -1
|
jonathan-longe
commented
Mar 17, 2023
Comment on lines
+2
to
+3
| <ViewWrapper> | ||
| <section class="pb-10" id="alteration-view"> |
There was a problem hiding this comment.
The wrapper is added in each view like this.
jonathan-longe
commented
Mar 17, 2023
Comment on lines
+41
to
-80
| <AlterationSummary | ||
| class="mt-10" | ||
| :sectionNumber="showTransactionalFolioNumber ? '4.' : '3.'" | ||
| :autoValidation="getAppValidate" | ||
| :validate="getAppValidate" | ||
| @haveChanges="onAlterationSummaryChanges()" | ||
| /> | ||
|
|
||
| <StaffPayment | ||
| <DocumentsDelivery | ||
| class="mt-10" | ||
| :sectionNumber="showTransactionalFolioNumber ? '5.' : '4.'" | ||
| @haveChanges="onStaffPaymentChanges()" | ||
| sectionNumber="1." | ||
| :validate="getAppValidate" | ||
| @valid="setDocumentOptionalEmailValidity($event)" | ||
| /> | ||
| </template> |
There was a problem hiding this comment.
This hasn't changed. It's just Github being dumb with how it recognizes changes.
jonathan-longe
commented
Mar 17, 2023
Comment on lines
-654
to
-669
|
|
||
| it('renders the fee summary properly following changes', async () => { | ||
| store.state.stateModel.tombstone.entityType = 'SP' | ||
| store.state.stateModel.tombstone.filingType = 'changeOfRegistration' | ||
| store.state.stateModel.entitySnapshot = mockEntitySnapshot | ||
| store.state.stateModel.officeAddresses = mockAddresses | ||
| store.state.stateModel.filingData = { | ||
| filingTypeCode: 'FMCHANGE', | ||
| entityType: 'SP', | ||
| priority: false, | ||
| waiveFees: false | ||
| } | ||
| await Vue.nextTick() | ||
|
|
||
| expect(wrapper.findComponent(FeeSummaryShared).exists()).toBe(true) // not displayed initially | ||
| }) |
There was a problem hiding this comment.
Removed this test as FeeSummaryShared is no longer rendered with App.vue
ketaki-deodhar
approved these changes
Mar 17, 2023
JazzarKarim
approved these changes
Mar 17, 2023
severinbeauvais
approved these changes
Mar 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #: /bcgov/entity#15092
This is an incremental PR as the changes are potentially disruptive. The PR removes the fee summaries from App.vue and moves them to a ViewWrapper component that's added to the following views:
By removing the fee summary components from App.vue it gives us more flexibility to handle the actions from FeeSummaryShared differently.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the bcrs-entities-create-ui license (Apache 2.0).