14975-fix style and validation #457
Conversation
| @@ -640,6 +640,7 @@ export default class ListPeopleAndRoles extends Mixins(CommonMixin, OrgPersonMix | |||
| .actions-width { | |||
| min-width: 150px; | |||
| max-width: 150px; | |||
| padding: 0.35rem !important; | |||
| } | |||
There was a problem hiding this comment.
This fix is for point#2 - to align action buttons with the text
| <!-- <v-icon>mdi-circle-small</v-icon> --> | ||
| <v-icon v-if="isApplicantOrg" color="green darken-2" class="dir-valid">mdi-check</v-icon> | ||
| <v-icon v-else-if="!applicantOrgs" color="red">mdi-close</v-icon> | ||
| <v-icon v-else>mdi-circle-small</v-icon> | ||
| <span>A business or a corporation</span> |
There was a problem hiding this comment.
this is for point#1 - fix validations
Default Applicant:
Remove Person and add another Person
Remove Person and add Org
There was a problem hiding this comment.
^^ Looks great! 😃
Codecov Report
@@ Coverage Diff @@
## main #457 +/- ##
==========================================
- Coverage 85.70% 83.84% -1.87%
==========================================
Files 177 185 +8
Lines 3289 3510 +221
Branches 524 711 +187
==========================================
+ Hits 2819 2943 +124
- Misses 468 566 +98
+ Partials 2 1 -1
|
|
|
||
| @extend .actions-width; | ||
| margin-top: -8px; | ||
|
|
There was a problem hiding this comment.
Removed overall padding. margin-top at line 620 was being overridden by this (line 623). Reduced margin-top (line 620) to align with the column on left. It is misaligned in DEV as well. This fixes the alignment for other filings (Change, Correction and Conversion). I tested for all the other filing types
In DEV:
After Fix:
|
^^ I restarted the failed jobs -- looked like environment error, not code error. |
Thank you! |
| <v-icon v-else color="red">mdi-close</v-icon> | ||
| <!-- <v-icon>mdi-circle-small</v-icon> --> | ||
| <v-icon v-if="isApplicantPerson && hasApplicant" color="green darken-2" class="dir-valid">mdi-check</v-icon> | ||
| <v-icon v-else-if="!isApplicantOrg || !hasApplicant" color="red">mdi-close</v-icon> |
There was a problem hiding this comment.
Shows correct validation if more than one applicants in the List.
There was a problem hiding this comment.
Screenshot please :)
Issue #: /bcgov/entity#14975
Description of changes:
UX observations:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the bcrs-entities-create-ui license (Apache 2.0).