Skip to content

Commit

Permalink
Changes from UX feedback. (#513)
Browse files Browse the repository at this point in the history
  • Loading branch information
seeker25 authored Jul 12, 2023
1 parent 0007c73 commit 90b522e
Show file tree
Hide file tree
Showing 4 changed files with 57 additions and 7 deletions.
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "business-edit-ui",
"version": "4.4.8",
"version": "4.4.9",
"private": true,
"appName": "Edit UI",
"sbcName": "SBC Common Components",
Expand Down
54 changes: 51 additions & 3 deletions src/components/SpecialResolution/Resolution.vue
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,43 @@
</v-icon>
<span>{{ getEditLabel }}</span>
</v-btn>
<!-- Dropdown menu - allows us to change without having to undo. -->
<v-menu
v-if="(hasChanged && !isSpecialResolutionFiling) && !isEditing"
v-model="dropdown"
offset-y
left
nudge-bottom="4"
>
<template #activator="{ on }">
<v-btn
id="btn-more-actions"
text
small
color="primary"
v-on="on"
>
<v-icon>{{ dropdown ? 'mdi-menu-up' : 'mdi-menu-down' }}</v-icon>
</v-btn>
</template>
<v-list>
<v-list-item
id="btn-more-actions-edit"
class="v-list-item"
@click="isEditing = true; dropdown = false"
>
<v-list-item-subtitle>
<v-icon
small
color="primary"
>
mdi-pencil
</v-icon>
<span class="drop-down-action ml-1">{{ getEditLabel }}</span>
</v-list-item-subtitle>
</v-list-item>
</v-list>
</v-menu>
</div>
</v-col>
</v-row>
Expand Down Expand Up @@ -172,6 +209,7 @@ export default class Resolution extends Vue {
isEditing = true
hasChanged = false
dropdown = false
/** Displays an invalid section to user if form is invalid. */
get invalidResolutionSection (): boolean {
Expand Down Expand Up @@ -244,8 +282,18 @@ export default class Resolution extends Vue {
}
}
.actions .undo-action {
border-right: 0px;
}
.actions {
position: absolute;
right: 0;
.undo-action {
border-right: 1px solid $gray1;
border-top-right-radius: 0;
border-bottom-right-radius: 0;
}
.v-btn {
min-width: 0.5rem;
}
}
</style>
4 changes: 3 additions & 1 deletion src/components/common/YourCompany/AssociationType.vue
Original file line number Diff line number Diff line change
Expand Up @@ -263,8 +263,10 @@ export default class AssociationType extends Mixins(CommonMixin) {
position: absolute;
right: 0;
.undo-action{
.undo-action {
border-right: 1px solid $gray1;
border-top-right-radius: 0;
border-bottom-right-radius: 0;
}
.v-btn {
Expand Down

0 comments on commit 90b522e

Please sign in to comment.