Skip to content

Commit

Permalink
- app version = 4.10.6 (#583)
Browse files Browse the repository at this point in the history
- replaced @volar-plugins/vetur by volar-service-vetur
- deleted obsolete title and description from resource interface
- deleted title and description from resource files (8)
- deleted title and description from HTML template

Co-authored-by: Severin Beauvais <severin.beauvais@gov.bc.ca>
  • Loading branch information
severinbeauvais and Severin Beauvais authored Aug 27, 2024
1 parent f46a197 commit 07a5481
Show file tree
Hide file tree
Showing 12 changed files with 168 additions and 148 deletions.
273 changes: 165 additions & 108 deletions package-lock.json

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "business-edit-ui",
"version": "4.10.5",
"version": "4.10.6",
"private": true,
"appName": "Edit UI",
"sbcName": "SBC Common Components",
Expand Down Expand Up @@ -73,7 +73,6 @@
"@typescript-eslint/eslint-plugin": "^5.59.2",
"@typescript-eslint/parser": "^5.59.2",
"@vitejs/plugin-vue2": "^2.2.0",
"@volar-plugins/vetur": "latest",
"@vue/eslint-config-standard": "^4.0.0",
"@vue/eslint-config-typescript": "^9.1.0",
"@vue/test-utils": "^1.3.5",
Expand All @@ -88,6 +87,7 @@
"vite": "4.5.2",
"vite-plugin-environment": "^1.1.3",
"vitest": "0.33.0",
"volar-service-vetur": "^0.0.54",
"vue-property-decorator": "^9.1.2",
"vue-test-utils-helpers": "git+https://github.com/bcgov/vue-test-utils-helpers.git",
"vuelidate-property-decorators": "1.0.28",
Expand Down
2 changes: 0 additions & 2 deletions src/interfaces/resource-interfaces/resource-interface.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,6 @@ export interface ResourceIF {
displayName: string
entityType?: CorpTypeCd // corrections only
addressLabel: string
title?: string // BEN corrections only
description?: string // BEN corrections only
filingData: FilingDataIF
additionalFilingData?: FilingDataIF,
changeData?: {
Expand Down
3 changes: 0 additions & 3 deletions src/resources/Correction/BC.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,6 @@ export const CorrectionResourceBc: ResourceIF = {
displayName: null, // not used
entityType: CorpTypeCd.BC_COMPANY,
addressLabel: 'Registered Office',
title: 'Benefit Company Statement',
description: 'This company is a benefit company and, as such, has purposes that include conducting its business in' +
' a responsible and sustainable manner and promoting one or more public benefits.',
filingData: {
filingTypeCode: FilingCodes.CORRECTION,
entityType: CorpTypeCd.BC_COMPANY,
Expand Down
3 changes: 0 additions & 3 deletions src/resources/Correction/BEN.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,6 @@ export const CorrectionResourceBen: ResourceIF = {
displayName: null, // not used
entityType: CorpTypeCd.BENEFIT_COMPANY,
addressLabel: 'Registered Office',
title: 'Benefit Company Statement',
description: 'This company is a benefit company and, as such, has purposes that include conducting its business in' +
' a responsible and sustainable manner and promoting one or more public benefits.',
filingData: {
filingTypeCode: FilingCodes.CORRECTION,
entityType: CorpTypeCd.BENEFIT_COMPANY,
Expand Down
3 changes: 0 additions & 3 deletions src/resources/Correction/C.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,6 @@ export const CorrectionResourceC: ResourceIF = {
displayName: null, // not used
entityType: CorpTypeCd.CONTINUE_IN,
addressLabel: 'Registered Office',
title: 'Benefit Company Statement',
description: 'This company is a benefit company and, as such, has purposes that include conducting its business in' +
' a responsible and sustainable manner and promoting one or more public benefits.',
filingData: {
filingTypeCode: FilingCodes.CORRECTION,
entityType: CorpTypeCd.CONTINUE_IN,
Expand Down
3 changes: 0 additions & 3 deletions src/resources/Correction/CBEN.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,6 @@ export const CorrectionResourceCben: ResourceIF = {
displayName: null, // not used
entityType: CorpTypeCd.BEN_CONTINUE_IN,
addressLabel: 'Registered Office',
title: 'Benefit Company Statement',
description: 'This company is a benefit company and, as such, has purposes that include conducting its business in' +
' a responsible and sustainable manner and promoting one or more public benefits.',
filingData: {
filingTypeCode: FilingCodes.CORRECTION,
entityType: CorpTypeCd.BEN_CONTINUE_IN,
Expand Down
3 changes: 0 additions & 3 deletions src/resources/Correction/CC.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,6 @@ export const CorrectionResourceCc: ResourceIF = {
displayName: null, // not used
entityType: CorpTypeCd.BC_CCC,
addressLabel: 'Registered Office',
title: 'Benefit Company Statement',
description: 'This company is a benefit company and, as such, has purposes that include conducting its business in' +
' a responsible and sustainable manner and promoting one or more public benefits.',
filingData: {
filingTypeCode: FilingCodes.CORRECTION,
entityType: CorpTypeCd.BC_CCC,
Expand Down
3 changes: 0 additions & 3 deletions src/resources/Correction/CCC.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,6 @@ export const CorrectionResourceCcc: ResourceIF = {
displayName: null, // not used
entityType: CorpTypeCd.CCC_CONTINUE_IN,
addressLabel: 'Registered Office',
title: 'Benefit Company Statement',
description: 'This company is a benefit company and, as such, has purposes that include conducting its business in' +
' a responsible and sustainable manner and promoting one or more public benefits.',
filingData: {
filingTypeCode: FilingCodes.CORRECTION,
entityType: CorpTypeCd.CCC_CONTINUE_IN,
Expand Down
3 changes: 0 additions & 3 deletions src/resources/Correction/CUL.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,6 @@ export const CorrectionResourceCul: ResourceIF = {
displayName: null, // not used
entityType: CorpTypeCd.ULC_CONTINUE_IN,
addressLabel: 'Registered Office',
title: 'Benefit Company Statement',
description: 'This company is a benefit company and, as such, has purposes that include conducting its business in' +
' a responsible and sustainable manner and promoting one or more public benefits.',
filingData: {
filingTypeCode: FilingCodes.CORRECTION,
entityType: CorpTypeCd.ULC_CONTINUE_IN,
Expand Down
3 changes: 0 additions & 3 deletions src/resources/Correction/ULC.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,6 @@ export const CorrectionResourceUlc: ResourceIF = {
displayName: null, // not used
entityType: CorpTypeCd.BC_ULC_COMPANY,
addressLabel: 'Registered Office',
title: 'Benefit Company Statement',
description: 'This company is a benefit company and, as such, has purposes that include conducting its business in' +
' a responsible and sustainable manner and promoting one or more public benefits.',
filingData: {
filingTypeCode: FilingCodes.CORRECTION,
entityType: CorpTypeCd.BC_ULC_COMPANY,
Expand Down
13 changes: 1 addition & 12 deletions src/views/Correction/CorpCorrection.vue
Original file line number Diff line number Diff line change
Expand Up @@ -14,16 +14,6 @@
</p>
</section>

<section
id="benefit-company-statement"
class="mt-6"
>
<p>
<span id="benefit-company-statement-label">{{ correctionResource.title }}:</span>
{{ correctionResource.description }}
</p>
</section>

<YourCompanyWrapper class="mt-10">
<div>
<EntityName />
Expand Down Expand Up @@ -215,8 +205,7 @@ export default class CorpCorrection extends Mixins(CommonMixin, DateMixin, FeeMi
</script>

<style lang="scss" scoped>
#original-filing-date-label,
#benefit-company-statement-label {
#original-filing-date-label {
letter-spacing: -0.04rem;
font-weight: bold;
}
Expand Down

0 comments on commit 07a5481

Please sign in to comment.