Skip to content

Commit

Permalink
- lint fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
severinbeauvais committed Sep 14, 2022
1 parent 61ae0fa commit 040c1e3
Show file tree
Hide file tree
Showing 17 changed files with 25 additions and 34 deletions.
11 changes: 6 additions & 5 deletions src/interfaces/payment-interfaces/fees-interface.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,10 @@
/** Interfaces for Fees from Payment API. */

export interface TaxesIF {
pst: number
gst: number
}

export interface FeesIF {
filingFees: number
filingType: string
Expand All @@ -11,11 +17,6 @@ export interface FeesIF {
total?: number
}

export interface TaxesIF {
pst: number
gst: number
}

// NB: use cloneDeep when assigning EmptyOrgPerson
export const EmptyFees: FeesIF = {
filingFees: null,
Expand Down
Original file line number Diff line number Diff line change
@@ -1,8 +1,3 @@
export interface ShareStructureIF {
valid: boolean
shareClasses: ShareClassIF[]
}

export interface ShareClassIF {
id: string
type?: string // 'Class' or 'Series'
Expand All @@ -17,6 +12,11 @@ export interface ShareClassIF {
series?: ShareClassIF[]
}

export interface ShareStructureIF {
valid: boolean
shareClasses: ShareClassIF[]
}

export const NewShareClass: ShareClassIF = {
id: null,
type: 'Class',
Expand Down
8 changes: 6 additions & 2 deletions src/mixins/add-edit-org-person-mixin.ts
Original file line number Diff line number Diff line change
Expand Up @@ -502,13 +502,17 @@ export default class AddEditOrgPersonMixin extends Vue {

// Event emitters
@Emit('addEditPerson')
private emitPersonInfo (personInfo: OrgPersonIF): void {}
private emitPersonInfo (personInfo: OrgPersonIF): OrgPersonIF {
return personInfo
}

@Emit('resetEvent')
private emitResetEvent (): void {}

@Emit('removePerson')
protected emitRemovePerson (activeIndex: number): void {}
protected emitRemovePerson (activeIndex: number): number {
return activeIndex
}

@Emit('removeCompletingPartyRole')
private emitReassignCompletingPartyEvent (): void {}
Expand Down
3 changes: 2 additions & 1 deletion src/mixins/filing-template-mixin.ts
Original file line number Diff line number Diff line change
Expand Up @@ -250,7 +250,7 @@ export default class FilingTemplateMixin extends Mixins(DateMixin) {

// conditionally restore the entity-specific sections
switch (this.getEntityType) {
case CorpTypeCd.COOP:
case CorpTypeCd.COOP: {
// restore Cooperative type
this.setCooperativeType(draftFiling.incorporationApplication.cooperative?.cooperativeAssociationType)

Expand Down Expand Up @@ -295,6 +295,7 @@ export default class FilingTemplateMixin extends Mixins(DateMixin) {
this.setMemorandum(createMemorandum)

break
}
case CorpTypeCd.BENEFIT_COMPANY:
case CorpTypeCd.BC_CCC:
case CorpTypeCd.BC_COMPANY:
Expand Down
1 change: 1 addition & 0 deletions src/router/router.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ export function getVueRouter () {
// set base URL for Vue Router
base: sessionStorage.getItem('VUE_ROUTER_BASE'),
routes,
// eslint-disable-next-line @typescript-eslint/no-unused-vars
scrollBehavior (to, from, savedPosition) {
// see https://router.vuejs.org/guide/advanced/scroll-behavior.html
return { x: 0, y: 0 }
Expand Down
1 change: 1 addition & 0 deletions src/services/legal-services.ts
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ export default class LegalServices {
.then(response => {
// look for dissolution task
const filing = response?.data?.tasks
// eslint-disable-next-line no-prototype-builtins
?.find(x => x.task.filing.hasOwnProperty(FilingTypes.VOLUNTARY_DISSOLUTION))?.task.filing
const filingName = filing?.header?.name
const filingId = +filing?.header?.filingId || 0
Expand Down
1 change: 1 addition & 0 deletions src/store/getters/state-getters.ts
Original file line number Diff line number Diff line change
Expand Up @@ -292,6 +292,7 @@ export const getBusinessContact = (state: StateIF): ContactPointIF => {
}

/** The Memorandum object. */
// eslint-disable-next-line @typescript-eslint/no-unused-vars
export const getMemorandum = (state: StateIF): any => {
return {} // FUTURE: implement this
}
Expand Down
1 change: 0 additions & 1 deletion tests/unit/Actions.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,6 @@ describe('Actions component', () => {
describe('Emits error event if NR validation fails in file and pay', () => {
let wrapper: any
const { assign } = window.location
const effectiveDate = new Date(new Date().setDate(new Date().getDate() + 5))

beforeEach(async () => {
// mock the window.location.assign function
Expand Down
4 changes: 0 additions & 4 deletions tests/unit/AddNameTranslation.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,6 @@ Vue.use(Vuelidate)
const vuetify = new Vuetify({})
const store = getVuexStore()

function resetStore (): void {
store.state.stateModel.nameTranslations = []
}

// Local references
const addTranslationInput = '#name-translation-input'
const doneBtn = '#btn-done'
Expand Down
1 change: 0 additions & 1 deletion tests/unit/BusinessTypeConfirm.spec.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import Vue from 'vue'
import flushPromises from 'flush-promises'
import { Wrapper } from '@vue/test-utils'
import { getLastEvent } from '../get-last-event'
import { wrapperFactory } from '../jest-wrapper-factory'
Expand Down
1 change: 0 additions & 1 deletion tests/unit/CompleteResolution.spec.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import Vue from 'vue'
import { wrapperFactory } from '../jest-wrapper-factory'
import CompleteResolution from '@/components/Dissolution/CompleteResolution.vue'
import { DissolutionResources } from '@/resources'
Expand Down
2 changes: 1 addition & 1 deletion tests/unit/DissolutionFirm.spec.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import Vuetify from 'vuetify'
import { shallowWrapperFactory } from '../jest-wrapper-factory'
import { mount, shallowMount } from '@vue/test-utils'
import { mount } from '@vue/test-utils'
import { getVuexStore } from '@/store'
import DissolutionFirm from '@/views/DissolutionFirm/DissolutionFirm.vue'
import { DissolutionResources } from '@/resources/'
Expand Down
3 changes: 0 additions & 3 deletions tests/unit/DissolutionReviewConfirm.spec.ts
Original file line number Diff line number Diff line change
@@ -1,10 +1,7 @@
import { shallowWrapperFactory, wrapperFactory } from '../jest-wrapper-factory'
import { getVuexStore } from '@/store'
import DissolutionReviewConfirm from '@/views/Dissolution/DissolutionReviewConfirm.vue'
import { DissolutionResources } from '@/resources/'

const store = getVuexStore()

// Test Case Data
const reviewConfirmTestCases = [
{
Expand Down
2 changes: 1 addition & 1 deletion tests/unit/IncorporationDateTime.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import { getLastEvent } from '../get-last-event'
import { getVuexStore } from '@/store'

// Utils
import { createLocalVue, mount, Wrapper } from '@vue/test-utils'
import { createLocalVue, mount } from '@vue/test-utils'

// Components
import IncorporationDateTime from '@/components/Incorporation/IncorporationDateTime.vue'
Expand Down
4 changes: 0 additions & 4 deletions tests/unit/ListNameTranslations.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,6 @@ const vuetify = new Vuetify({})
const store = getVuexStore()
document.body.setAttribute('data-app', 'true')

function resetStore (): void {
store.state.stateModel.nameTranslations = []
}

// Local references
const nameTranslationsUi = '#name-translations-list'
const nameTranslationsList = [
Expand Down
1 change: 0 additions & 1 deletion tests/unit/RegAddEditOrgPerson.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ const middleNameSelector = '.middle-name'
const lastNameSelector = '.last-name'
const confirmCheckboxSelector = '.confirm-checkbox'
const orgNameSelector = '.org-name'
const businessNumberSelector = '.business-number'
const emailAddressSelector = '.email-address'
const buttonRemoveSelector = '.btn-remove'
const buttonDoneSelector = '.btn-done'
Expand Down
5 changes: 1 addition & 4 deletions tests/unit/RegistrationReviewConfirm.spec.ts
Original file line number Diff line number Diff line change
@@ -1,10 +1,7 @@
import { shallowWrapperFactory, wrapperFactory } from '../jest-wrapper-factory'
import { getVuexStore } from '@/store'
import { shallowWrapperFactory } from '../jest-wrapper-factory'
import { RegistrationReviewConfirm } from '@/views'
import { RegistrationResources } from '@/resources'

const store = getVuexStore()

// Test Case Data
const reviewConfirmTestCases = [
{
Expand Down

0 comments on commit 040c1e3

Please sign in to comment.