Updated interfaces to import other interfaces locally #64
Conversation
| @@ -1,5 +1,4 @@ | |||
| import { IncorporationAddressIf, ShareClassIF, | |||
| NameTranslationIF } from '@/interfaces' | |||
| import { IncorporationAddressIf, ShareClassIF, NameTranslationIF } from './' | |||
There was a problem hiding this comment.
The previous code had this interface looking in the parent's "interfaces" folder for these imports. This is incorrect. This interface should look in THIS folder for any imports.
Any shared interface (or mixin, enum, etc) should be able to get everything it needs from the current folder structure (ie, this shared repo).
It's slightly different if an interface needs an enum... In this case, the interface should import from "@bcrs-shared-components/enums" so that it gets the versioned one.
|
So, a bunch of components were updated as a result of this interface import change:
In my current ticket (6554), I only need the updated interfaces (1.0.20) and staff-payment (1.0.23). I think no other dependenies (in any app) need to be updated at this time, since they obviously didn't experience the import issue I did. If and when they need an updated component, then at that time they can update their dependency(ies) (and do the appropriate testing, etc). |
Issue #: /bcgov/entity#6554
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the business-filings-ui license (Apache 2.0).