Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up for the new domain name changes. #135

Merged
merged 1 commit into from
Apr 19, 2023
Merged

Conversation

pwei1018
Copy link
Collaborator

Issue #: 15877

Description of changes:

  1. Clean up unused files;
  2. Enable cloud build PR review feature;
  3. Move firebase and cloud build configuration to UI CD flow in bcregisty-sre repo;
  4. Update environment variables' value;

@pwei1018
Copy link
Collaborator Author

/gcbrun

@pwei1018
Copy link
Collaborator Author

Temporary Url for review: https://yfthig-dev--pr-135-ekorc4xp.web.app

@pwei1018
Copy link
Collaborator Author

/gcbrun

@pwei1018
Copy link
Collaborator Author

Temporary Url for review: https://yfthig-dev--pr-135-ekorc4xp.web.app

@@ -1,6 +1,6 @@
{
"name": "bc-registry",
"version": "2.0.4",
"version": "2.1.0",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

major version upgrade and nothing has changed other than CI/CD :(

it's fine

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a minor version change and files were deleted.

Copy link
Collaborator

@cameron-eyds cameron-eyds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG!

@pwei1018 pwei1018 merged commit 8603df4 into bcgov:main Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants