Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ostruct gem to Gemfile to prevent an error in development with Ruby 3.5 #1098

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

koic
Copy link
Collaborator

@koic koic commented Feb 6, 2025

This PR adds ostruct gem to Gemfile to fix the following Ruby 3.5 CI build error:

An error occurred while loading ./spec/acceptance/typhoeus/typhoeus_hydra_spec.rb. - Did you mean?
                    rspec ./spec/acceptance/typhoeus/typhoeus_hydra_spec_helper.rb

Failure/Error: require 'ostruct'

LoadError:
  cannot load such file -- ostruct
# ./spec/acceptance/typhoeus/typhoeus_hydra_spec_helper.rb:1:in '<top (required)>'
# ./spec/acceptance/typhoeus/typhoeus_hydra_spec.rb:5:in '<top (required)>'

https://github.com/bblimke/webmock/actions/runs/13171078861/job/36761473227?pr=1097

Avoiding the use of OpenStruct is certainly an option, but since this module is only used in tests, the simplest solution has been chosen.

…Ruby 3.5

This PR adds `ostruct` gem to Gemfile to fix the following Ruby 3.5 CI build error:

```console
An error occurred while loading ./spec/acceptance/typhoeus/typhoeus_hydra_spec.rb. - Did you mean?
                    rspec ./spec/acceptance/typhoeus/typhoeus_hydra_spec_helper.rb

Failure/Error: require 'ostruct'

LoadError:
  cannot load such file -- ostruct
# ./spec/acceptance/typhoeus/typhoeus_hydra_spec_helper.rb:1:in '<top (required)>'
# ./spec/acceptance/typhoeus/typhoeus_hydra_spec.rb:5:in '<top (required)>'
```

https://github.com/bblimke/webmock/actions/runs/13171078861/job/36761473227?pr=1097

Avoiding the use of `OpenStruct` is certainly an option, but since this module is only used in tests,
the simplest solution has been chosen.
@koic koic merged commit ab43ce9 into bblimke:master Feb 6, 2025
7 of 9 checks passed
@koic koic deleted the add_ostruct_to_gemfile branch February 6, 2025 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant