Remove runtime dependency on base64
#1046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ruby 3.3 shows a warning when using base64 without declaring it in the gemspec. Ruby 3.4 will remove base64 as a default gem.
|
As of 2 weeks ago, it looks like Ruby head has now removed the default base64 gem entirely. So projects that use webmock fail with this exception:
A workaround exists: any project using webmock also has to add base64 to their Gemfile. Still, it would be nice to see this PR merged. Thanks! 🙏 |
|
@Earlopain thank you for providing this solution. I appreciate the simplicity! 👍 It's great to have a solution that doesn't require adding another dependency to the gemspec. |
This was referenced Feb 5, 2024
2 tasks
JuanVqz
added a commit
to fastruby/next_rails
that referenced
this pull request
Feb 4, 2025
Ruby 3.4 is removing the `base64` default gem to [became bundled](https://rubyreferences.github.io/rubychanges/3.4.html#default-gems-that-became-bundled) Making the current webmock (v3.16.2) gem incompatible because it has a dependency on the `base64` gem, to fix it we are bumping webmock to v3.20.0 which [removed the `base64`](bblimke/webmock#1046) dependency. As an alternative solution, we can leave the current `webmock` version untoched and add the `base64` gem as a dependency. Given this message: `limited on purpose, new versions don't work with old rubies` we might lost support of some old rubies.
JuanVqz
added a commit
to fastruby/next_rails
that referenced
this pull request
Feb 4, 2025
Ruby 3.4 is removing the `base64` default gem to [became bundled](https://rubyreferences.github.io/rubychanges/3.4.html#default-gems-that-became-bundled) Making the current webmock (v3.16.2) gem incompatible because it has a dependency on the `base64` gem, to fix it we are bumping webmock to v3.20.0 which [removed the `base64`](bblimke/webmock#1046) dependency. > [!NOTE] > As an alternative solution, we can leave the current `webmock` version untoched and add the `base64` gem as a dependency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ruby 3.3 shows a warning when using base64 without declaring it in the gemspec. Ruby 3.4 will remove base64 as a default gem.
Since this gem is only using a single method in one place there is no need to pull in the full dependency. It is only a wrapper over
Array#pack.Alternative to #1041
Other gems have taken the same/similar approach:
base64gem from runtime dependency rubocop/rubocop#12313