Add support for centaur-tabs, doom-modeline, and solaire-mode #330
Conversation
|
Just 2 things:
|
|
I've thought of that, but couldn't find a suitable colour for it. Perhaps I'll try again. Right now the screenshot looks like:
|
|
[Update]: I have edited the snippet to be: However, for the unselected tab foreground, there seems to be only dark grey in the variable that the original author defined (to dark to be visible). Therefore I suggest that we stick to "#909090" |
zenburn-theme.el
Outdated
| @@ -1535,6 +1535,16 @@ Also bind `class' to ((class color) (min-colors 89))." | |||
| ;;;;; yascroll | |||
| `(yascroll:thumb-text-area ((t (:background ,zenburn-bg-1)))) | |||
| `(yascroll:thumb-fringe ((t (:background ,zenburn-bg-1 :foreground ,zenburn-bg-1)))) | |||
|
|
|||
| ;;;;; Centaur Tabs | |||
There was a problem hiding this comment.
Nit: The list of packages is sorted by lexicographic order, so centaur-tabs should come after calfw and before cider.
There was a problem hiding this comment.
Also the comment should be centaur-tabs right?
|
@ianpan870102 I propose this one, what do you think?: ;;;;; centaur-tabs
`(centaur-tabs-default ((t (:background ,zenburn-bg :foreground ,zenburn-fg :box nil))))
`(centaur-tabs-selected ((t (:background ,zenburn-bg :foreground ,zenburn-fg :box nil))))
`(centaur-tabs-unselected ((t (:background ,zenburn-bg-1 :foreground ,zenburn-fg-1 :box nil))))
`(centaur-tabs-selected-modified ((t (:background ,zenburn-bg :foreground ,zenburn-orange :box nil))))
`(centaur-tabs-unselected-modified ((t (:background ,zenburn-bg-1 :foreground ,zenburn-orange :box nil))))
`(centaur-tabs-active-bar-face ((t (:background ,zenburn-yellow :box nil))))
`(centaur-tabs-modified-marker-selected ((t (:inherit 'centaur-tabs-selected-modified :foreground ,zenburn-yellow :box nil))))
`(centaur-tabs-modified-marker-unselected ((t (:inherit 'centaur-tabs-unselected-modified :foreground ,zenburn-yellow :box nil))))The :box nil part is completely necessary because if not the icons will look bad, and the zenburn-fg-1 will do it instead of the "#909090" and the zenburn-fg will do it instead of the "white" It looks like this: Also, could you pleas add the following configuration for doom-modeline so it matches centaur-tabs? ;;;;; doom-modeline
`(doom-modeline-bar ((t (:background ,zenburn-yellow))))
`(doom-modeline-inactive-bar ((t (:background nil)))) |
|
Ah thanks for the If not, I agree to go with your proposal, using variables is always better than static coding. |
|
@basil-conto @ema2159 @bbatsov
|
|
Looking really good! |
|
Thanks for that PR. A bit of small feedback from me:
|
add support for centaur tabs use zenburn-yellow as modified tab indication remove old centaur tabs config add custom local variable to be squashed add support for solaire-mode rename colour variable
|
@bbatsov Thanks for the feedback! I have made my commits significantly cleaner, clearing diverging branches and squashing them to an overview commit. I have also capitalized the message and placed Regarding |
|
If not new colors should be introduced then you could set the solaire background to the same color as the centaur tabs default background and use the already existing zenburn-fgs, all depends on mr @bbatsov opinion |
Let's give the new colour a shot. We can always change it down the line. Thanks for the in depth explanation of your reasoning! |
Sure! Thanks a lot |
Seeing that Centaur Tabs is a growing package (I personally love it!), I've added the following color support for it.