Escape periods in "projectile-globally-ignored-directories"

[maxtrussell]

The unescaped periods were causing unexpected directories to be ignored.

E.g. for the following go project, the configitem directory was ignored because it matched the regex ".git":

$ find pkg -type f
pkg/metrics/argus.go
pkg/secrets/secrets.go
pkg/dynamo/dynamo.go
pkg/utils/types.go
pkg/utils/utils.go
pkg/utils/errors.go
pkg/configitem/configitem.go
pkg/api/handlers.go
pkg/api/middleware.go

Replace this placeholder text with a summary of the changes in your PR.
The more detailed you are, the better.

---

Before submitting a PR make sure the following things have been done (and denote this
by checking the relevant checkboxes):

• The commits are consistent with our contribution guidelines
• You've added tests (if possible) to cover your change(s)
• All tests are passing (eldev test)
• The new code is not generating bytecode or M-x checkdoc warnings
• You've updated the changelog (if adding/changing user-visible functionality)
• You've updated the readme (if adding/changing user-visible functionality)

Thanks!

[bbatsov]

Can you elaborate on this a bit? I was under the impression the items on this list were used for literal matches, but if they are used as regular expressions we can make them more specific.

[maxtrussell]

Can you elaborate on this a bit? I was under the impression the items on this list were used for literal matches, but if they are used as regular expressions we can make them more specific.

@bbatsov Happy to! The items on the list end up getting passed to projectile-ignored-directory-p here: https://github.com/bbatsov/projectile/blob/master/projectile.el#L1308-L1313

Which in turn passes the list to a string-match-p here: https://github.com/bbatsov/projectile/blob/master/projectile.el#L1726-L1729

Now confusingly string-match-p seems to match using regular expressions. You can find the docs for it on this page: https://www.gnu.org/software/emacs/manual/html_node/elisp/Regexp-Search.html

ELISP> (string-match-p ".git" "configitem")
4 (#o4, #x4, ?\C-d)
ELISP> (string-match-p "\\.git" "configitem")
nil
ELISP> (string-match-p "\\.git" ".git")
0 (#o0, #x0, ?\C-@)

Note any non-nil output from string-match-p indicates a match. The return value is just the index of the match within the string.

Also the comments on projectile-globally-ignored-directories directly mention that regular expressions are used: https://github.com/bbatsov/projectile/blob/master/projectile.el#L417

It's probably worth adding start and end anchors to projectile-globally-ignored-directories so that wacky directory names like "foo.git.bar" won't be ignored

[bbatsov]

It's probably worth adding start and end anchors to projectile-globally-ignored-directories so that wacky directory names like "foo.git.bar" won't be ignored

Agreed.

[maxtrussell]

It's probably worth adding start and end anchors to projectile-globally-ignored-directories so that wacky directory names like "foo.git.bar" won't be ignored

Agreed.

Done

[bbatsov]

Thanks!