Fix file paths in projectile-replace* with prefix arg #1655
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When prefix arg is supplied and a directory is selected, the directory
passed to projectile-dir-files is not necessarily the project root, so
using projectile-expand-root yields incorrect behavior.
For example, in a project rooted at
~/project
with files:With
C-u M-x projectile-replace-regexp
, selecting directory~/project/foo/
, projectile incorrectly attempts to read file~/project/bar.c
, resulting in an error.Before submitting a PR make sure the following things have been done (and denote this
by checking the relevant checkboxes):
eldev test
)M-x checkdoc
warningsYou've updated the readme (if adding/changing user-visible functionality)Thanks!
When running
eldev test
, I see that two tests fail, but they also fail in master, so I don't think it has anything to do with this PR.