Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for OCaml dune projects #1576

Merged
merged 1 commit into from
Sep 2, 2020
Merged

Conversation

hongchangwu
Copy link
Contributor

@hongchangwu hongchangwu commented Aug 26, 2020

Although relatively new, Dune has become the de-facto standard build tool for OCaml. The vast majority of packages on Opam uses Dune now.

Reference for project root file: https://dune.readthedocs.io/en/stable/overview.html?highlight=dune-project#project-layout


Before submitting a PR make sure the following things have been done (and denote this
by checking the relevant checkboxes):

  • The commits are consistent with our contribution guidelines
  • You've added tests (if possible) to cover your change(s)
  • All tests are passing (eldev test)
  • The new code is not generating bytecode or M-x checkdoc warnings
  • You've updated the changelog (if adding/changing user-visible functionality)
  • You've updated the readme (if adding/changing user-visible functionality)

Thanks!

@hongchangwu hongchangwu force-pushed the dune branch 3 times, most recently from 6f00b5f to 97f6016 Compare August 26, 2020 05:03
@bbatsov bbatsov merged commit 1104e44 into bbatsov:master Sep 2, 2020
@bbatsov
Copy link
Owner

bbatsov commented Sep 2, 2020

Thanks!

@hongchangwu hongchangwu deleted the dune branch September 2, 2020 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants