Cache root in non-file-backed buffers #1213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`projectile-cached-buffer-file-name` would be set to nil in non-file-backed buffers causing the root caching to not work. `'none` is used as a sentinel value for `projectile-project-root-cache` so this reuses that for `projectile-cached-buffer-file-name` as well.
f24e49d to
26ca619
Compare
|
I'm not sure how to add tests for this... let me know if that's a problem. Thanks! |
|
Looks good to me! Normally the test for this would involve creating some buffer, let-binding a bit of config, running |
bbatsov
reviewed
Jan 28, 2018
| @@ -905,10 +905,10 @@ will return the current directory, otherwise it'd raise an error." | |||
| ;; instead | |||
| (or (cl-subst nil 'none | |||
| (or (and projectile-cached-buffer-file-name | |||
| (equal projectile-cached-buffer-file-name buffer-file-name) | |||
| (equal projectile-cached-buffer-file-name (or buffer-file-name 'none)) | |||
There was a problem hiding this comment.
Btw, we could have also wrapped this in a (when buffer-file-name which might have been more clear, but this came to my mind only after I merged this. Anyways, not a big deal.
There was a problem hiding this comment.
Wrapped which? I tried wrapping the whole thing in that previously and it broke some functionality for me.
|
Also, thanks for the merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting a PR make sure the following things have been done (and denote this
by checking the relevant checkboxes):
make test)M-x checkdocwarningsThanks!