Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fossil checkout database is named
.fslckout
or_FOSSIL_
, not.fossil
. Searching for a dominating .fossil file would just find~/.fossil
, which is Fossil's user config database.I made the changes
projectile-project-vcs
such that when it searches for a Fossil repo checkout in the current directory or looks for the dominating project file, it tries.fslckout
, then_FOSSIL_
for the reasons described above.@npostavs identified the needed changes in #1022's comment thread.
There were no existing tests for
projectile-project-vcs
, and figured having Fossil as a test dependency would be no good, so I did not add or change any tests for this.I did a manual:
Created a Fossil repo and checked it out, and ran
touch .projectile
.Ran
fossil add .projectile; fossil commit -m "add projetcile file"; touch test.txt
Verified that
projectile-find-file
listed.projectile
but nottest.txt
.Before submitting a PR make sure the following things have been done (and denote this
by checking the relevant checkboxes):
make test
)M-x checkdoc
warningsThanks!