Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruby 2.3 compatibility for binary_wrapper #75

Merged
merged 5 commits into from
Jul 15, 2020

Conversation

lalten
Copy link
Contributor

@lalten lalten commented Jul 3, 2020

Applies the suggestions from #63 (comment)

@lalten lalten requested review from kigster and yugui as code owners July 3, 2020 12:21
Copy link
Contributor

@kigster kigster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kigster kigster merged commit 6f08698 into bazelruby:develop Jul 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants