[Fix] no spaces in files bug, remove deprecated code, remove host #38
+40
−98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ocop, remove host
…y/rules_ruby into graham/remove-host-fix-excludes
kigster
approved these changes
Dec 16, 2019
|
|
||
| ``` | ||
| bundle lock --update |
| @@ -122,28 +117,10 @@ def main(args) | |||
| end | |||
| end | |||
| end | |||
| exec(ruby_program, '--disable-gems', *rubyopt, main, *args) | |||
| exec(ruby_program, *rubyopt, main, *args) | |||
There was a problem hiding this comment.
Yes, I also didn't understand why we need to disable ruby gems.
Speaking of ruby gems — when you install a brand new Ruby interpreter, remember to run gem update --system — this only needs to run once because rubygems rarely get upgraded, but with Ruby 2.6 this will bring Bundler version 2 as part of RubyGems.
|
|
||
| exclude_array = excludes[spec.name] || [] | ||
| # We want to exclude files and folder with spaces in them | ||
| exclude_array += ["**/* *.*", "**/* */*"] |
There was a problem hiding this comment.
Why can't we work with folder with spaces in them? Just curious.
There was a problem hiding this comment.
Bazel does not like them because it creates a runfile target name out of the file path which breaks it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
bundle_installto be ruby based, making it easier to specify specific parts to includeis_hostfrom the ruby toolchain, as now the assumption is that ruby is built and running on the system, either using the local binary if the versions match, or installing a new version. This deprecates and remove some of @yugui's work in Run ruby_binary with the interpreter in a SDK again #22. We may later refer to this and reintroduce in this in a different manner.'--disable-gems',from ruby_binary as many ruby binaries depend on ruby gems. I am unsure of why this was excluded. For an example whereGemis required in a ruby_binary look at https://github.com/rubocop-hq/rubocop/blob/master/lib/rubocop/yaml_duplication_checker.rb@bundler//:libsand:@bundler//:allI think, like with go, we should encourage being specific about which gems are being depended on. This will help later when we optimize the installation of gems to only install gems that are needed for a specific build/target.