Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass -no-emit-module-separately by default #785

Merged
merged 1 commit into from
Mar 22, 2022

Conversation

keith
Copy link
Member

@keith keith commented Mar 21, 2022

This fixes #775 by
disabling the optimization intended by swiftlang/swift-driver@e0c3e5c

Ideally we wouldn't disable it, but that caused other issues
#784 and this is no worse
than what Swift 5.5 was doing until we find a better fix.

@keith keith marked this pull request as ready for review March 21, 2022 05:26
This fixes #775 by
disabling the optimization intended by swiftlang/swift-driver@e0c3e5c

Ideally we wouldn't disable it, but that caused other issues
#784 and this is no worse
than what Swift 5.5 was doing until we find a better fix.
@keith keith force-pushed the ks/pass-no-emit-module-separately-by-default branch from 4a37c79 to 1ea2035 Compare March 21, 2022 05:27
@keith keith enabled auto-merge (rebase) March 21, 2022 05:27
@lyft-lint-bot
Copy link

Lyft integration job started: https://buildkite.com/lyft/rules-swift/builds/265 (must be Lyft employee to view)

Copy link
Member

@thii thii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the feature name start with an _, like other private features?

swift/internal/feature_names.bzl Show resolved Hide resolved
swift/internal/swift_autoconfiguration.bzl Show resolved Hide resolved
swift/internal/xcode_swift_toolchain.bzl Show resolved Hide resolved
swift/internal/xcode_swift_toolchain.bzl Show resolved Hide resolved
swift/internal/swift_autoconfiguration.bzl Show resolved Hide resolved
swift/internal/compiling.bzl Show resolved Hide resolved
swift/internal/compiling.bzl Show resolved Hide resolved
@keith
Copy link
Member Author

keith commented Mar 21, 2022

I considered that, the reason I didn't do it originally is in the case this has some unintended side effect I didn't want to train people to disable private features that have the underscore

@keith keith merged commit 517dc7d into master Mar 22, 2022
@keith keith deleted the ks/pass-no-emit-module-separately-by-default branch March 22, 2022 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Xcode 13.3 Beta 3 swift_binary not building
3 participants