Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn instead of fail when swiftc not found on Linux #1433

Merged
merged 2 commits into from
Oct 22, 2024
Merged

Warn instead of fail when swiftc not found on Linux #1433

merged 2 commits into from
Oct 22, 2024

Conversation

brentleyjones
Copy link
Collaborator

No description provided.

@brentleyjones
Warn instead of fail when swiftc not found on Linux
b265e74 
Signed-off-by: Brentley Jones <github@brentleyjones.com>
@brentleyjones
Copy link
Collaborator Author

Not sure if we should even warn here. Doing it for now though.

@brentleyjones
More
0ea2cb4 
Signed-off-by: Brentley Jones <github@brentleyjones.com>
@brentleyjones
Copy link
Collaborator Author

Context: https://bazelbuild.slack.com/archives/CD3QY5C2X/p1729618421756879?thread_ts=1729547052.242209&cid=CD3QY5C2X

@brentleyjones brentleyjones merged commit a8d7635 into master Oct 22, 2024
12 checks passed
@brentleyjones brentleyjones deleted the bj/warn-instead-of-fail-when-swiftc-not-found-on-linux branch October 22, 2024 19:25
brentleyjones added a commit that referenced this pull request Oct 22, 2024
@brentleyjones
Warn instead of fail when swiftc not found on Linux (#1433)
bd0e6e0 
Signed-off-by: Brentley Jones <github@brentleyjones.com>
(cherry picked from commit a8d7635)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cerisier cerisier cerisier approved these changes

@BalestraPatrick BalestraPatrick Awaiting requested review from BalestraPatrick BalestraPatrick is a code owner

@keith keith Awaiting requested review from keith keith is a code owner

@luispadron luispadron Awaiting requested review from luispadron luispadron is a code owner

@mattrobmattrob mattrobmattrob Awaiting requested review from mattrobmattrob mattrobmattrob is a code owner

@thii thii Awaiting requested review from thii thii is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brentleyjones @cerisier