Fix build_file labels
#1425
Merged
Fix build_file labels
#1425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattrobmattrob
approved these changes
Oct 22, 2024
|
We would have to have another workspace that loads this one, since it the labels do resolve correctly from within the repo. I think that's too much hassle for something that shouldn't really break again. And yeah, I'm not 100% sure we will support WORKSPACE in rules_swift 3.0. |
Regressed for WORKSPACE users in 7fafc9b. Signed-off-by: Brentley Jones <github@brentleyjones.com>
de50737 to
3859dd9
Compare
|
Sounds good to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regressed for WORKSPACE users in 7fafc9b.