Capture macro expansions in an output group named macro_expansions during debug builds
#1355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…during debug builds LLDB wants these files to be present on the file system to step into macro expansions, because their file paths are recorded in debug info. The compiler uses `TMPDIR` (if set) as the location for those files, so we can have the worker set `TMPDIR` to a target-specific location before spawning `swiftc`. If this location is workspace-relative, then those file paths are also remapped via `-debug-prefix-map`—an added bonus. The `macro_expansions` group will contain a tree (directory) artifact that contains a `swift-generated-sources` subdirectory (the compiler forces that name), which contains one or more `.swift` files representing the expanded macro buffers. PiperOrigin-RevId: 549932429 (cherry picked from commit 69349ee) Cherry-pick notes: We already included most of this in c9d1f5f. This just restricts `_macro_expansion_configurator` to debug builds. Signed-off-by: Brentley Jones <github@brentleyjones.com>
brentleyjones
referenced
this pull request
Oct 7, 2024
…during debug builds. LLDB wants these files to be present on the file system to step into macro expansions, because their file paths are recorded in debug info. The compiler uses `TMPDIR` (if set) as the location for those files, so we can have the worker set `TMPDIR` to a target-specific location before spawning `swiftc`. If this location is workspace-relative, then those file paths are also remapped via `-debug-prefix-map`—an added bonus. The `macro_expansions` group will contain a tree (directory) artifact that contains a `swift-generated-sources` subdirectory (the compiler forces that name), which contains one or more `.swift` files representing the expanded macro buffers. PiperOrigin-RevId: 549932429
luispadron
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LLDB wants these files to be present on the file system to step into macro expansions, because their file paths are recorded in debug info. The compiler uses
TMPDIR(if set) as the location for those files, so we can have the worker setTMPDIRto a target-specific location before spawningswiftc. If this location is workspace-relative, then those file paths are also remapped via-debug-prefix-map—an added bonus.The
macro_expansionsgroup will contain a tree (directory) artifact that contains aswift-generated-sourcessubdirectory (the compiler forces that name), which contains one or more.swiftfiles representing the expanded macro buffers.PiperOrigin-RevId: 549932429
(cherry picked from commit 69349ee)
Cherry-pick notes: We already included most of this in c9d1f5f. This just restricts
_macro_expansion_configuratorto debug builds.