Extract derive_swift_module_name as a free function in its own .bzl file
#1347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l` file Since rules may want to use this without the other functionality in `swift_common` (e.g., compilation), isolating it to its own file can reduce analysis churn when other parts of the rule implementations change. PiperOrigin-RevId: 493078921 (cherry picked from commit 47bd14c) Signed-off-by: Brentley Jones <github@brentleyjones.com>
brentleyjones
referenced
this pull request
Oct 7, 2024
…l` file. Since rules may want to use this without the other functionality in `swift_common` (e.g., compilation), isolating it to its own file can reduce analysis churn when other parts of the rule implementations change. PiperOrigin-RevId: 493078921
mattrobmattrob
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since rules may want to use this without the other functionality in
swift_common(e.g., compilation), isolating it to its own file can reduce analysis churn when other parts of the rule implementations change.PiperOrigin-RevId: 493078921
(cherry picked from commit 47bd14c)