Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotate the test observer with @MainActor where needed to be concurrency-safe #1263

Merged
merged 1 commit into from
Jun 21, 2024
Merged

Annotate the test observer with @MainActor where needed to be concurrency-safe #1263

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions tools/test_observer/BazelXMLTestObserver.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ public final class BazelXMLTestObserver: NSObject {
///
/// If the `XML_OUTPUT_FILE` environment variable is not set or the file at that path could not be
/// created and opened for writing, the value of this property will be nil.
@MainActor
public static let `default`: BazelXMLTestObserver? = {
guard
let outputPath = ProcessInfo.processInfo.environment["XML_OUTPUT_FILE"],
Expand Down
1 change: 1 addition & 0 deletions tools/test_observer/BazelXMLTestObserverRegistration.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
/// The principal class in an XCTest bundle on Darwin-based platforms, which registers the
/// XML-generating observer with the XCTest observation center when the bundle is loaded.
@objc(BazelXMLTestObserverRegistration)
@MainActor
public final class BazelXMLTestObserverRegistration: NSObject {
@objc public override init() {
super.init()
Expand Down