Skip to content

Commit

Permalink
Delete the swift.bundled_xctests feature.
Browse files Browse the repository at this point in the history
PiperOrigin-RevId: 471797061
  • Loading branch information
allevato authored and swiple-rules-gardener committed Sep 2, 2022
1 parent 0727866 commit 585e7a7
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 9 deletions.
7 changes: 0 additions & 7 deletions swift/internal/feature_names.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -44,13 +44,6 @@ SWIFT_FEATURE_BITCODE_EMBEDDED_MARKERS = "swift.bitcode_embedded_markers"
# the note above about not depending on the C++ features.)
SWIFT_FEATURE_COVERAGE = "swift.coverage"

# If enabled, the `swift_test` rule will output an `.xctest` bundle for Darwin
# targets instead of a standalone binary. This is necessary for XCTest-based
# tests that use runtime reflection to locate test methods. This feature can be
# explicitly disabled on a per-target or per-package basis if needed to make
# `swift_test` output just a binary.
SWIFT_FEATURE_BUNDLED_XCTESTS = "swift.bundled_xctests"

# If enabled, debug builds will use the `-debug-prefix-map` feature to remap the
# current working directory to `.`, which permits debugging remote or sandboxed
# builds.
Expand Down
2 changes: 0 additions & 2 deletions swift/toolchains/xcode_swift_toolchain.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ load(
"@build_bazel_rules_swift//swift/internal:feature_names.bzl",
"SWIFT_FEATURE_BITCODE_EMBEDDED",
"SWIFT_FEATURE_BITCODE_EMBEDDED_MARKERS",
"SWIFT_FEATURE_BUNDLED_XCTESTS",
"SWIFT_FEATURE_DEBUG_PREFIX_MAP",
"SWIFT_FEATURE_ENABLE_BATCH_MODE",
"SWIFT_FEATURE_MODULE_MAP_HOME_IS_CWD",
Expand Down Expand Up @@ -729,7 +728,6 @@ def _xcode_swift_toolchain_impl(ctx):
_features_for_bitcode_mode(cpp_fragment.apple_bitcode_mode),
)
requested_features.extend([
SWIFT_FEATURE_BUNDLED_XCTESTS,
SWIFT_FEATURE_ENABLE_BATCH_MODE,
SWIFT_FEATURE_USE_RESPONSE_FILES,
SWIFT_FEATURE_DEBUG_PREFIX_MAP,
Expand Down

1 comment on commit 585e7a7

@brentleyjones
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.