Enable swift.use_response_files by default on Linux (#1013)

All versions of Swift we support can use this
bazelbuild · Feb 17, 2023 · 1bc3e29 · 1bc3e29
1 parent 8c6a03f
commit 1bc3e29
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 15 deletions.
diff --git a/swift/internal/swift_autoconfiguration.bzl b/swift/internal/swift_autoconfiguration.bzl
@@ -117,20 +117,6 @@ print("Hello")
         source_file,
     )
 
-def _check_use_response_files(repository_ctx, swiftc_path, temp_dir):
-    """Returns True if `swiftc` supports the use of response files."""
-    param_file = _scratch_file(
-        repository_ctx,
-        temp_dir,
-        "check-response-files.params",
-        "-version",
-    )
-    return _swift_succeeds(
-        repository_ctx,
-        swiftc_path,
-        "@{}".format(param_file),
-    )
-
 def _check_supports_lld_gc_workaround(repository_ctx, swiftc_path, temp_dir):
     """Returns True if lld is being used and it supports nostart-stop-gc"""
     source_file = _scratch_file(
@@ -226,7 +212,6 @@ _FEATURE_CHECKS = {
     SWIFT_FEATURE_LLD_GC_WORKAROUND: _check_supports_lld_gc_workaround,
     SWIFT_FEATURE_SUPPORTS_BARE_SLASH_REGEX: _check_enable_bare_slash_regex,
     SWIFT_FEATURE_SUPPORTS_PRIVATE_DEPS: _check_supports_private_deps,
-    SWIFT_FEATURE_USE_RESPONSE_FILES: _check_use_response_files,
 }
 
 def _normalized_linux_cpu(cpu):

diff --git a/swift/internal/swift_toolchain.bzl b/swift/internal/swift_toolchain.bzl
@@ -293,6 +293,7 @@ def _swift_toolchain_impl(ctx):
         SWIFT_FEATURE_NO_GENERATED_MODULE_MAP,
         SWIFT_FEATURE_OPT_USES_WMO,
         SWIFT_FEATURE_USE_GLOBAL_MODULE_CACHE,
+        SWIFT_FEATURE_USE_RESPONSE_FILES,
     ])
 
     requested_features.extend(ctx.features)