Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create .bazelrc #572

Merged
merged 3 commits into from
Aug 3, 2018
Merged

Create .bazelrc #572

merged 3 commits into from
Aug 3, 2018

Conversation

cvcal
Copy link
Contributor

@cvcal cvcal commented Aug 3, 2018

@ittaiz
Copy link
Member

ittaiz commented Aug 3, 2018

Thanks!
I think this change will conflict with our travis setup (https://github.com/bazelbuild/rules_scala/blob/master/.travis.yml#L45).
WDYT?

@cvcal
Copy link
Contributor Author

cvcal commented Aug 3, 2018

Ah, yes. Buildkite and travis run completely independently, yes? In that case I can modify https://github.com/bazelbuild/rules_scala/blob/master/.bazelci/presubmit.yml instead

cvcal added 2 commits August 3, 2018 15:19
It would be nicer to simply change the "mv" command, but I'm not 100% sure that this would always run with HEAD bazel, so this provides some duality if both formats need to be supported concurrently.
It conflicts with the travis setup.
@cvcal
Copy link
Contributor Author

cvcal commented Aug 3, 2018

Or we could make the travis import be to tools/bazel.rc, and for the .bazelrc file import it either way, but then if we're in neither travis or buildkite, it's got an import to nowhere.

@cvcal cvcal merged commit b537bdd into master Aug 3, 2018
gergelyfabian pushed a commit to gergelyfabian/rules_scala that referenced this pull request May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants