JacocoRunner script: update for Bazel 5.0+ #1399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgraded jacoco package name for Bazel 5.0+. Upgraded jacoco from 0.8.3 to 0.8.6. Jacoco upgrade to 0.8.6 was made in Bazel in: bazelbuild/bazel#11674 bazelbuild/bazel@cb7c1a2 Removed options for workarounds where those have been fixed in the meantime: Bazel's handling for branch coverage was fixed in: bazelbuild/bazel#12696 Instead of changing the existing script for building Jacoco, added a new one that can be used for Bazel 5.0.
667b9ff to
b1c1e18
Compare
|
Added a change to have both versions of the script, pre-Bazel-5.0 and post-Bazel-5.0. |
liucijus
approved these changes
Jun 2, 2022
…va 17 bazelbuild/bazel#15081 fixed a bug when using coverage with Scala targets on Java 17. Use the tag 6.0.0-pre.20220520.1 where this was fixed.
|
Updated Bazel's tag to avoid an error reported in #1400. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
JacocoRunner builder script needs an update for Bazel 5.0+.
Upgraded jacoco package name for Bazel 5.0+.
Upgraded jacoco from 0.8.3 to 0.8.6.
Jacoco upgrade to 0.8.6 was made in Bazel in:
bazelbuild/bazel#11674
bazelbuild/bazel@cb7c1a2
Removed options for workarounds where those have been fixed in the meantime:
Bazel's handling for branch coverage was fixed in:
bazelbuild/bazel#12696
Motivation
If you use a custom-built Jacoco version for Bazel <5.0, then when you upgrade Bazel to 5.0+ you'll need to rebuild that custom Jacoco version, otherwise your coverage executions would fail with an error similar to the following: