Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

specs2 support #72

Closed
ittaiz opened this issue Jun 7, 2016 · 4 comments
Closed

specs2 support #72

ittaiz opened this issue Jun 7, 2016 · 4 comments

Comments

@ittaiz
Copy link
Member

ittaiz commented Jun 7, 2016

Hi,
Most of our tests use specs2 (a small portion uses JUnit and a handful use scalatest).
Do you think specs2 support should be part of this library?
If so do you think it should be via a flag to scala_test? via an additional rule?
Not sure I like the fact that scalatest is always on the classpath even if I don't need it but might be negligible.

I can add this support in an external repo but I think it's more natural for it to reside here.

@ittaiz
Copy link
Member Author

ittaiz commented Jun 14, 2016

I'm actually closing this one since we actually use the JUnit runner to run our specs2 tests (SpecificationWithJUnit) and so I'll just solve it locally with compiling using the mix_java_scala and then running a JUnit runner ( in sh_test?)

@ittaiz ittaiz closed this as completed Jun 14, 2016
@johnynek
Copy link
Member

Sorry I didn't reply sooner. I think a scala_specs_test could be fine to
add. I don't see a good way to do it in one rule.

I don't think you need the scalatest dependency if you don't use the rule.

On Monday, June 13, 2016, Ittai Zeidman notifications@github.com wrote:

Closed #72 #72.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#72 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/AAEJdkLvZPJ3jc7sV1eQSTlNYnl2y3zCks5qLjKXgaJpZM4Ivzaq
.

P. Oscar Boykin, Ph.D. | http://twitter.com/posco | http://pobox.com/~boykin

@ittaiz
Copy link
Member Author

ittaiz commented Jun 14, 2016

No worries at all, hope you enjoyed the getaway and congratulations :)
Do you want me to reopen the issue?
Like I said I don't need this currently but others might. I might even get around to it later on but now I'm trying to face my blockers.

@johnynek
Copy link
Member

Well, we can leave it closed if you have a work around (at least give us
the impression the issue count is not too high. ;)

On Mon, Jun 13, 2016 at 7:14 PM, Ittai Zeidman notifications@github.com
wrote:

No worries at all, hope you enjoyed the getaway and congratulations :)
Do you want me to reopen the issue?
Like I said I don't need this currently but others might. I might even get
around to it later on but now I'm trying to face my blockers.


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#72 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AAEJdqtXa1OPSqbmpSYFc42GipdO2j0Kks5qLjingaJpZM4Ivzaq
.

P. Oscar Boykin, Ph.D. | http://twitter.com/posco | http://pobox.com/~boykin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants