Add support for ppc64le architecture #3259
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UebelAndre
requested changes
Feb 12, 2025
| @@ -117,7 +117,7 @@ def get_host_triple(repository_ctx, abi = None): | |||
| # Detect the host's cpu architecture | |||
|
|
|||
| supported_architectures = { | |||
| "linux": ["aarch64", "x86_64", "s390x"], | |||
| "linux": ["aarch64", "x86_64", "s390x", "powerpc64le"], | |||
There was a problem hiding this comment.
Is the host platform ever gonna be powerpc? I think the only changes you need are what was done in rust/platform/triple_mappings.bzl.
There was a problem hiding this comment.
If I understand correctly, the host platform is the platform the bazel binary is executed on. When attempting to utilize rules_rust and executing bazel on a ppc64le host, I did receive the failure message from _validate_cpu_architecture, causing the build to fail. Marking it as supported here seems necessary to avoid failure in that case.
Allow rules_rust module to be used on the ppc64le architecture. Signed-off-by: James Jenkins <James.Jenkins@ibm.com>
33e9753 to
7390d92
Compare
UebelAndre
approved these changes
Feb 27, 2025
|
@Jenkins-J Looks like this PR will need to be rebased and the crate_universe examples repinned. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow rules_rust module to be used on the ppc64le architecture.