-
Notifications
You must be signed in to change notification settings - Fork 561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pip_parse
and pip_install
can now parse entry points from wheels
#523
Conversation
0e5c7ea
to
7b7579d
Compare
daf4f5a
to
6ec6075
Compare
6ec6075
to
7856f94
Compare
This is awesome! thanks, I'll merge and go patch into a client codebase and see if we can remove some of our wrappers. I bet the working directory issue will still be a problem, but that's a missing feature in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🌮
PR Checklist
Please check if your PR fulfills the following requirements:
.par
files. See CONTRIBUTING.md for infoPR Type
What kind of change does this PR introduce?
What is the current behavior?
Currently, there is no way to access binaries (or entry points) associated with a wheel in python. This has been a rather annoying problem since it expects users to manually generate it themselves. A process for which there's currently there's no guidance on. This PR aims to solve that by generating these targets automatically.
Issue Number: #341
What is the new behavior?
Both pip_install and pip_parse now generate
py_binary
targets for each entry point in a wheel. These are accessible via theentry_point
macro which has been added to therequirements.bzl
files generated by these repository rules.To use this new functionality, you simply load the
entry_point
macro:Then. the target can be run just like any other
py_binary
.Does this PR introduce a breaking change?
Other information