refactor(uv): move around uv implementation files #2580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR starts establishing a structure that will eventually become a part of our API. This is a prerequisite for bazelbuild#2578 which removes the versions.bzl file in favour of a more dynamic configuration of the extension. We also remove the `defs.bzl` to establish a one symbol per file convention. Things that I wish we could change is `//python/uv:extensions.bzl` and the fact that we have `extensions` in the load path. I think it cannot be removed, because that may break the BCR test. On the other hand, maybe we could remove it and do an alpha release to verify this assumption. Work towards bazelbuild#1975
3 tasks
rickeylev
approved these changes
Jan 26, 2025
|
I think it should be OK for BCR because it sets dev_dependency. When BCR runs, it creates a root module that depends on the module-under-test/release. A way to check this would be to add a dev dep use_extension() of a non-existent path in rules_python, then run one of the examples. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR starts establishing a structure that will eventually become a
part of our API. This is a prerequisite for #2578 which removes the
versions.bzl file in favour of a more dynamic configuration of the
extension. We also remove the
defs.bzlto establish a one symbol perfile convention.
Things that I wish we could change is
//python/uv:extensions.bzlandthe fact that we have
extensionsin the load path. I think it cannotbe removed, because that may break the BCR test. On the other hand,
maybe we could remove it and do an alpha release to verify this
assumption.
Work towards #1975