Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

incompatible_depset_union #175

Closed
laurentlb opened this issue Apr 14, 2019 · 1 comment · Fixed by #180
Closed

incompatible_depset_union #175

laurentlb opened this issue Apr 14, 2019 · 1 comment · Fixed by #180
Assignees
@brandjon
Labels
P1 type: bug

Comments

@laurentlb
Copy link
Contributor

This command: bazel build ... --incompatible_depset_union
fails with the message:

ERROR: /var/lib/buildkite-agent/builds/bk-docker-5r85/bazel-downstream-projects/rules_python/experimental/examples/wheel/BUILD:65:1: in py_wheel rule //experimental/examples/wheel:customized:
--
  | Traceback (most recent call last):
  | File "/var/lib/buildkite-agent/builds/bk-docker-5r85/bazel-downstream-projects/rules_python/experimental/examples/wheel/BUILD", line 65
  | py_wheel(name = 'customized')
  | File "/var/lib/buildkite-agent/builds/bk-docker-5r85/bazel-downstream-projects/rules_python/experimental/python/wheel.bzl", line 145, in _py_wheel_impl
  | inputs.union([description_file])
  | depset method `.union` has been removed. See https://docs.bazel.build/versions/master/skylark/depsets.html for recommendations.

Please take a look, we're going to flip the flag soon.
@brandjon brandjon self-assigned this Apr 15, 2019
@pstradomski
Copy link
Contributor

Should be straightforward to fix. I'll try to send a PR by the end of the week

@pstradomski pstradomski mentioned this issue Apr 16, 2019
Merged
guibou added a commit to tweag/rules_haskell that referenced this issue Jun 25, 2019
@guibou
Switch --incompatible_depset_union
6068a27 
See: bazelbuild/rules_python#175
guibou added a commit to tweag/rules_haskell that referenced this issue Jun 26, 2019
@guibou
Switch --incompatible_depset_union
1a904bb 
See: bazelbuild/rules_python#175
guibou added a commit to tweag/rules_haskell that referenced this issue Jun 26, 2019
@guibou
Switch --incompatible_depset_union
fb6e474 
See: bazelbuild/rules_python#175
guibou added a commit to tweag/rules_haskell that referenced this issue Jun 26, 2019
@guibou
Switch --incompatible_depset_union
4d6877f 
See: bazelbuild/rules_python#175
guibou added a commit to tweag/rules_haskell that referenced this issue Jun 26, 2019
@guibou
Switch --incompatible_depset_union
5fc81f3 
See: bazelbuild/rules_python#175
guibou added a commit to tweag/rules_haskell that referenced this issue Jun 26, 2019
@guibou
Switch --incompatible_depset_union
2d03222 
See: bazelbuild/rules_python#175
guibou added a commit to tweag/rules_haskell that referenced this issue Jun 26, 2019
@guibou
Switch --incompatible_depset_union
4da3229 
See: bazelbuild/rules_python#175
guibou added a commit to tweag/rules_haskell that referenced this issue Jun 27, 2019
@guibou
Switch --incompatible_depset_union
3e5acf1 
See: bazelbuild/rules_python#175
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brandjon brandjon

Labels
P1 type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Stop using deprecated depset.union API
3 participants
@laurentlb @brandjon @pstradomski