Skip to content

Commit

Permalink
fix: apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Richard Levasseur <richardlev@gmail.com>
  • Loading branch information
f0rmiga and rickeylev authored Nov 28, 2022
1 parent 906bb6a commit c60f069
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion python/config_settings/transition.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ def _transition_py_impl(ctx):
env = {}
for k, v in ctx.attr.env.items():
env[k] = ctx.expand_location(v)

providers = [
DefaultInfo(
executable = executable,
Expand All @@ -51,7 +52,11 @@ def _transition_py_impl(ctx):
),
target[PyInfo],
target[PyRuntimeInfo],
target[InstrumentedFilesInfo],
# Ensure that the binary we're wrapping is included in code coverage.
coverage_common.instrumented_files_info(
ctx,
dependency_attributes = ["target"],
),
target[OutputGroupInfo],
# TODO(f0rmiga): testing.TestEnvironment is deprecated in favour of RunEnvironmentInfo but
# RunEnvironmentInfo is not exposed in Bazel < 5.3.
Expand Down

0 comments on commit c60f069

Please sign in to comment.