Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove repository mapping #897

Closed
wants to merge 2 commits into from

Conversation

comius
Copy link
Contributor

@comius comius commented Dec 20, 2022

Rename all dev_io_bazel_rules_kotlin to io_bazel_rules_kotlin and remove repo_mapping.

bzlmod takes over full control of repo_mapping, uses it to control "strict repo dependencies" and thus removes the parameter from repository rule

This undo-es some of the previous work done to prevent mixing of development repository and released repos.

Works toward: #660

@comius comius marked this pull request as ready for review December 20, 2022 17:26
Copy link
Collaborator

@Bencodes Bencodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm but might want to have @restingbull give this a once over.

@restingbull restingbull self-assigned this Dec 21, 2022
@restingbull
Copy link
Collaborator

restingbull commented Dec 21, 2022

I'd rather this wasn't merged. Besides changing unnecessary strings, it can be more cleanly handled with the release_archive.

Aside from that, this change is several steps back from proper separation of dev and prod runtimes, which in turn makes it harder to move to a proper bootstrap, and away from the kt_bootstrap rules (which don't cache, or work nicely with libraries, etc. etc.) One of the major reasons for the development repository naming is to shake out all the places that the standard io_bazel_rules_kotlin was hard coded (this later caused strange bugs)

I'm assuming that bzlmod remaps the repositories based on the core workspace name?

@restingbull
Copy link
Collaborator

A cursory glance over the docs, indicates that opts repos may best be mapped as extensions.

@comius
Copy link
Contributor Author

comius commented Dec 22, 2022

several steps back from proper separation of dev and prod runtimes
Sorry, I had no intention to do that. Thanks for providing some more insight on why you have this separation.

I think I can make progress to support bzlmod in a different way, so I'll close this PR for now.

@comius comius closed this Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants