Fix using rules_kotlin from head #571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… choosing compiler versions. Signed-off-by: restingbull@cabaretmechanique.com <restingbull@cabaretmechanique.com>
|
Wait, this is burying the lede, isn't it? are you enabling 1.5 with this commit? |
Shoot, no. Lemme go fix that. |
|
@cgruber @restingbull what are the issues w/ 1.5 we are still looking to fix? |
I'm doing 1.5 in another pr. |
cgruber
approved these changes
Aug 16, 2021
| } | ||
|
|
||
| kotlin_repositories(compiler_release = KOTLINC_RELEASE) | ||
| kotlin_repositories( |
There was a problem hiding this comment.
Ugh, thank you for this. I should have done this kotlinc_version thing a long time ago.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update local development instructions
Move release_archive to source directory
Add
kotlinc_versionhelper for choosing compiler versions.Fixes Issue #570
Signed-off-by: restingbull@cabaretmechanique.com restingbull@cabaretmechanique.com