Skip to content
This repository has been archived by the owner on Feb 6, 2024. It is now read-only.

Merge #84 into master #89

Merged
merged 4 commits into from
Dec 14, 2017
Merged

Merge #84 into master #89

merged 4 commits into from
Dec 14, 2017

Conversation

mattmoor
Copy link
Contributor

@ensonic FYI

ensonic and others added 4 commits December 13, 2017 18:25
@ensonic
Mention the tools that the rules shell out to.
ad26b12 
This is useful to know for setting up a hermetic build environment.
See #80
@ensonic
Make the namespace attribute on k8s_object optional.
f24d1da 
Only pass the --namespace parameter to kubectl if the namespace attribute
is specified. This will let people specify this in the deployment template
instead.

See #81
@mattmoor
Merge pull request #84 from ensonic/master
ed6e5bd 
Two small improvements
@mattmoor
Fix problem with #84
63fd487
@mattmoor mattmoor merged commit b79c757 into master Dec 14, 2017
@nlopezgi nlopezgi deleted the pr-84 branch November 27, 2018 15:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattmoor @ensonic