Skip to content
This repository has been archived by the owner on Feb 6, 2024. It is now read-only.

Enable wrapping k8s_objects diff exit codes #680

Merged
merged 1 commit into from
Feb 7, 2022

Conversation

irlevesque
Copy link
Contributor

Fixes: #679

This diff proposes one strategy we could take to wrapping the command execution of the kubectl diffs in order to address the above issue.

@k8s-ci-robot
Copy link

Hi @irlevesque. Thanks for your PR.

I'm waiting for a bazelbuild member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@chases2
Copy link
Contributor

chases2 commented Jan 31, 2022

/ok-to-test

This looks like an acceptable option to me. Please be sure to:

  • Sign the CLA; the output to the failing presubmit provides instructions
  • Squash your 3 commits together into one

@irlevesque
Copy link
Contributor Author

@chases2 all set, thanks!

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chases2, irlevesque

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@chases2 chases2 merged commit d8ef983 into bazelbuild:master Feb 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

k8s_objects .diff target doesn't return all diffs
4 participants