Skip to content
This repository has been archived by the owner on Feb 6, 2024. It is now read-only.

Make //k8s:reverser and //k8s:stamper PY2 and PY3 compatible #461

Merged
merged 1 commit into from
Oct 30, 2019

Conversation

zegl
Copy link
Contributor

@zegl zegl commented Oct 30, 2019

  • Upgrade PyYAML to 5.1.2
  • Select the PY2 or PY3 version of PyYAML depending on the desired PY version

I've been testing this downstream, and have confirmed that rules such as .delete works with both --host_force_python=PY3 and --host_force_python=PY2.

* Upgrade PyYAML to 5.1.2
* Select the PY2 or PY3 version of PyYAML depending on the desired PY version
@k8s-ci-robot
Copy link

Hi @zegl. Thanks for your PR.

I'm waiting for a bazelbuild member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nlopezgi
Copy link
Contributor

/ok-to-test

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nlopezgi, zegl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nlopezgi nlopezgi merged commit a65e0e7 into bazelbuild:master Oct 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants