Skip to content
This repository has been archived by the owner on Feb 6, 2024. It is now read-only.

fix: building kubectl v1.14.3 fails with missing dependency #366

Merged
merged 2 commits into from
Jun 12, 2019

Conversation

codesuki
Copy link
Contributor

The kubernetes repo expects io_kubernetes_build to be called io_k8s_repo_infra.
If that repository is not available the build will fail with the following error message.
"error loading package '@io_kubernetes//staging/src/k8s.io/apimachinery/pkg/util/sets': Unable to find package for @io_k8s_repo_infra//defs:go.bzl: The repository '@io_k8s_repo_infra' could not be resolved."

Related change:
kubernetes/kubernetes@e216995

Fixes #358

This likely breaks backward compatibility with kubernetes < 1.14
Is there any good way to parse versions in skylark?

The kubernetes repo expects io_kubernetes_build to be called io_k8s_repo_infra.
If that repository is not available the build will fail with the following error message.
"error loading package '@io_kubernetes//staging/src/k8s.io/apimachinery/pkg/util/sets': Unable to find package for @io_k8s_repo_infra//defs:go.bzl: The repository '@io_k8s_repo_infra' could not be resolved."

Related change:
kubernetes/kubernetes@e216995
@k8s-ci-robot
Copy link

Hi @codesuki. Thanks for your PR.

I'm waiting for a bazelbuild member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@smukherj1
Copy link
Contributor

/ok-to-test

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: codesuki, smukherj1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 2e2d1e5 into bazelbuild:master Jun 12, 2019
@codesuki codesuki deleted the fix-kubectl branch June 12, 2019 22:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Building newest kubectl needs io_k8s_repo_infra
3 participants