Skip to content
This repository has been archived by the owner on Feb 6, 2024. It is now read-only.

Update go to 0.18.2 & disable go targets on Ubuntu 14.04 #310

Merged
merged 2 commits into from
Apr 12, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .bazelci/presubmit.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,10 @@ platforms:
- "-//images/gcloud-bazel:gcloud_installer"
- "-//images/gcloud-bazel:gcloud_install"
- "-//images/gcloud-bazel:gcloud-layer"
# Ubuntu 14.04 binutils is incompatible with Go 0.18.2.
# See buildkite CI failure in https://github.com/bazelbuild/rules_k8s/pull/309
- "-//examples/hellogrpc/go/..."
- "-//examples/hellohttp/go/..."
test_targets:
- "..."
ubuntu1604:
Expand Down
4 changes: 2 additions & 2 deletions WORKSPACE
Original file line number Diff line number Diff line change
Expand Up @@ -136,8 +136,8 @@ py_library(

http_archive(
name = "io_bazel_rules_go",
sha256 = "77dfd303492f2634de7a660445ee2d3de2960cbd52f97d8c0dffa9362d3ddef9",
url = "https://github.com/bazelbuild/rules_go/releases/download/0.18.1/rules_go-0.18.1.tar.gz",
sha256 = "31f959ecf3687f6e0bb9d01e1e7a7153367ecd82816c9c0ae149cd0e5a92bf8c",
url = "https://github.com/bazelbuild/rules_go/releases/download/0.18.2/rules_go-0.18.2.tar.gz",
)

load("@io_bazel_rules_go//go:deps.bzl", "go_register_toolchains", "go_rules_dependencies")
Expand Down
6 changes: 3 additions & 3 deletions k8s/k8s.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -52,9 +52,9 @@ py_library(
# here to keep all the http_archive calls in one function for simplicity.
http_archive(
name = "io_bazel_rules_go",
urls = ["https://github.com/bazelbuild/rules_go/archive/0.16.1.tar.gz"],
sha256 = "ced2749527318abeddd9d91f5e1555ed86e2b6bfd08677b750396e0ec5462bec",
strip_prefix = "rules_go-0.16.1",
urls = ["https://github.com/bazelbuild/rules_go/archive/0.18.2.tar.gz"],
sha256 = "31f959ecf3687f6e0bb9d01e1e7a7153367ecd82816c9c0ae149cd0e5a92bf8c",
strip_prefix = "rules_go-0.18.2",
)
if "k8s_config" not in excludes:
# WORKSPACE target to configure the kubectl tool
Expand Down