Skip to content
This repository has been archived by the owner on Feb 6, 2024. It is now read-only.

buildifier for objects.bzl #230

Merged
merged 1 commit into from
Nov 21, 2018
Merged

Conversation

nlopezgi
Copy link
Contributor

Just run buildifier on object.bzl so that my other pr (https://github.com/bazelbuild/rules_k8s/pull/229/files) is not a mess

@nlopezgi
Copy link
Contributor Author

/retest

@nlopezgi
Copy link
Contributor Author

/test pull-rules-k8s-e2e

@chrislovecnm
Copy link
Contributor

/lgtm

/approve

Copy link
Contributor

@chrislovecnm chrislovecnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrislovecnm, nlopezgi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@chrislovecnm
Copy link
Contributor

buildkite how I hate you

@nlopezgi
Copy link
Contributor Author

its the dang mac pulling of images that is very flaky, will consider disabling some of the mac tests.

@nlopezgi nlopezgi merged commit 2ced0eb into bazelbuild:master Nov 21, 2018
@nlopezgi nlopezgi deleted the buildifyK8s branch November 26, 2018 21:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants