This repository has been archived by the owner on Feb 6, 2024. It is now read-only.
Use /usr/bin/env bash for more portable shebang lines #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are still systems widely in use where bash does not exist at /bin/bash (e.g. NixOS), or where /bin/bash is an extremely outdated version of bash (MacOS). Using /usr/bin/env to locate bash increases portability. It's not hermetic, but /bin/bash was already not hermetic.
|
related: bazelbuild/rules_docker#381 |
|
/ok-to-test |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: benley, nlopezgi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
nlopezgi
approved these changes
Jul 25, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are still systems widely in use where bash does not exist at
/bin/bash(e.g. NixOS), or where/bin/bashis an extremely outdated version of bash (MacOS). Using/usr/bin/envto locate bash increases portability. It's not hermetic, but/bin/bashwas already not hermetic.