Skip to content
This repository has been archived by the owner on Feb 6, 2024. It is now read-only.

Do not clean between build/test #164

Merged
merged 2 commits into from
Jul 24, 2018
Merged

Do not clean between build/test #164

merged 2 commits into from
Jul 24, 2018

Conversation

fejta
Copy link
Contributor

@fejta fejta commented Jul 23, 2018

We have other contexts that ensure build/test work on various OSes, so this doesn't add additional coverage and just slows things down.

/assign @nlopezgi @erain

@k8s-ci-robot
Copy link

@fejta: GitHub didn't allow me to assign the following users: ensonic.

Note that only bazelbuild members and repo collaborators can be assigned.
For more information please see the contributor guide

In response to this:

We have other contexts that ensure build/test work on various OSes, so this doesn't add additional coverage and just slows things down.

/assign @nlopezgi @ensonic

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@fejta
Copy link
Contributor Author

fejta commented Jul 23, 2018

/assign @erain

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: erain, fejta, nlopezgi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [erain,fejta,nlopezgi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nlopezgi
Copy link
Contributor

/override Verify Pull Request
(just to try if that fixes issue with check)

@nlopezgi
Copy link
Contributor

Everything checked has passed and this is blocked on "Verify Pull Request" will force squash and merge.

@nlopezgi nlopezgi merged commit 2dddb0c into bazelbuild:master Jul 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants