Skip to content
This repository has been archived by the owner on Feb 6, 2024. It is now read-only.

Remove .short_path references #26

Closed
mattmoor opened this issue Sep 19, 2017 · 0 comments
Closed

Remove .short_path references #26

mattmoor opened this issue Sep 19, 2017 · 0 comments
Labels

Comments

@mattmoor
Copy link
Contributor

I recently replaced the use of f.short_path all over docker_build with _get_runfile_path to make it so that the scripts produced by things like :dev.create can be built and run separately.

rules_k8s exhibits the same symptom as the broken before picture, we should apply the same fixes here so that higher-level rules can bundle our actions into higher-level actions.

This links to both of my PRs so far fixing this class of issue.

mattmoor added a commit that referenced this issue Sep 20, 2017
This hinders two things:
1. Separate `bazel build` and running via `bazel-bin/...` (vs. `bazel run`)
1. Embedding these scripts into other actions.

This also changes the tool references from `.par` to the `py_binary` directly as this should improve portability to Windows.

Fixes: #26
mattmoor added a commit that referenced this issue Sep 21, 2017
This hinders two things:
1. Separate `bazel build` and running via `bazel-bin/...` (vs. `bazel run`)
1. Embedding these scripts into other actions.

This also changes the tool references from `.par` to the `py_binary` directly as this should improve portability to Windows.

Fixes: #26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant